-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(variables-scss): Add debug option for exporter #DS-1505 #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelklibani
requested review from
literat,
crishpeen,
curdaj and
a team
as code owners
October 4, 2024 08:43
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pavelklibani
force-pushed
the
feat/ds-1505-debug-option-for-exporter
branch
from
October 4, 2024 10:45
9759674
to
1bc17e5
Compare
curdaj
approved these changes
Oct 7, 2024
literat
reviewed
Oct 7, 2024
literat
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
pavelklibani
force-pushed
the
feat/ds-1505-debug-option-for-exporter
branch
from
October 7, 2024 15:48
8a63bbf
to
b8ba9ad
Compare
pavelklibani
force-pushed
the
feat/ds-1505-debug-option-for-exporter
branch
from
October 8, 2024 06:43
b8ba9ad
to
35824e2
Compare
rebased to main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding option to toggle generating original unformatted data from Supernova to our exporter.
You can enable this feature by setting the
generateOriginalDataFiles
option in theconfig.local.json
file.By default, this option is set to
false
.Additional context
Note
The
generateDisclaimer
option has been removed from the config for clarity.We never used this option. Our disclaimer is always displayed by default.
Issue reference
Exporter | add debug option for exporter