Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(variables-scss): Add debug option for exporter #DS-1505 #1683

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Oct 4, 2024

Description

Adding option to toggle generating original unformatted data from Supernova to our exporter.

You can enable this feature by setting the generateOriginalDataFiles option in the config.local.json file.
By default, this option is set to false.

Additional context

Note

The generateDisclaimer option has been removed from the config for clarity.
We never used this option. Our disclaimer is always displayed by default.

Issue reference

Exporter | add debug option for exporter

@pavelklibani pavelklibani self-assigned this Oct 4, 2024
@pavelklibani pavelklibani requested review from literat, crishpeen, curdaj and a team as code owners October 4, 2024 08:43
@github-actions github-actions bot added the feature New feature or request label Oct 4, 2024
Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 35824e2
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6704d49ba6242000087dfdb9

Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 58c2739
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66ffaa986f08ef00087cc97f
😎 Deploy Preview https://deploy-preview-1683--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 35824e2
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6704d49bd8bb5f00086adbb3
😎 Deploy Preview https://deploy-preview-1683--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Oct 4, 2024

Coverage Status

coverage: 78.751%. remained the same
when pulling 35824e2 on feat/ds-1505-debug-option-for-exporter
into e8b7bea on main.

@pavelklibani pavelklibani force-pushed the feat/ds-1505-debug-option-for-exporter branch from 9759674 to 1bc17e5 Compare October 4, 2024 10:45
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pavelklibani pavelklibani force-pushed the feat/ds-1505-debug-option-for-exporter branch from 8a63bbf to b8ba9ad Compare October 7, 2024 15:48
@pavelklibani pavelklibani force-pushed the feat/ds-1505-debug-option-for-exporter branch from b8ba9ad to 35824e2 Compare October 8, 2024 06:43
@pavelklibani
Copy link
Contributor Author

rebased to main

@pavelklibani pavelklibani merged commit 8aeab9a into main Oct 8, 2024
14 checks passed
@pavelklibani pavelklibani deleted the feat/ds-1505-debug-option-for-exporter branch October 8, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants