Make publishing packages on GitHub working #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
maintenance
literat
changed the title
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
literat
force-pushed
the
chore/DS-1434-prerelease
branch
3 times, most recently
from
1f04abf to
9bac127
Compare
literat
changed the title
crishpeen
approved these changes
Oct 10, 2024
refs #DS-1434
literat
force-pushed
the
chore/DS-1434-prerelease
branch
from
fa9cd7e to
b06d2f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The publishing workflow was not working correctly due to the fact that the workflow was run on every push. Not even to branch, but the tag as well. This causes running multiple actions at once, because Lerna pushes multiple tags, one for each package.
So I have prepared a condition for checking push to a branch with the tags on it. So only when there is a push to the main branch and the latest commit has tags the workflow will be run.
Additional context
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#onpushbranchestagsbranches-ignoretags-ignore
Issue reference
https://jira.almacareer.tech/browse/DS-1434