Fix(variables-scss): Export in JS barrel file #DS-1503

[curdaj]

Description

Additional context

Issue reference

[netlify]

✅ Deploy Preview for spirit-design-system ready!

Name	Link
🔨 Latest commit	bd4326b
🔍 Latest deploy log	https://app.netlify.com/sites/spirit-design-system/deploys/6707b3e0bea2750008662069
😎 Deploy Preview	https://deploy-preview-1687--spirit-design-system.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 96 (no change from production) Accessibility: 93 (no change from production) Best Practices: 100 (no change from production) SEO: 82 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[netlify]

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name	Link
🔨 Latest commit	bd4326b
🔍 Latest deploy log	https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6707b3e0bea2750008662065

[coveralls]

coverage: 78.751%. remained the same
when pulling 414b129 on fix/ds-1503-eslint-export-in-barrel-file
into 8aeab9a on main.

[literat]

I think it would be better to move theme.ts to theme/index.ts if possible. Because now we can import themes from index.ts and some parts also from theme.ts.

[literat]

Btw, in

export const themes = {
  themeLightDefault: {
    colors: themeLightDefault.colors
  },
  themeLightOnBrand: {
    colors: themeLightOnBrand.colors
  },
};

There should be a comma , at the end of the record -> colors: themeLightOnBrand.colors,

[literat]

Nice work. I have written a few suggestion for a better (and much smaller) ESLint configuration and also send a fixup with the ignore of the desing-tokens package from the root configuration.

Every package with its own ESLint configuration should be ignored by the root one so they are not in the collision (yeah, I know, this should be refactored).

[curdaj]

Btw, in

export const themes = {
  themeLightDefault: {
    colors: themeLightDefault.colors
  },
  themeLightOnBrand: {
    colors: themeLightOnBrand.colors
  },
};

There should be a comma , at the end of the record -> colors: themeLightOnBrand.colors,

already fixed

[curdaj]

I think it would be better to move theme.ts to theme/index.ts if possible. Because now we can import themes from index.ts and some parts also from theme.ts.

I am not sure if I understand and where the problem is.