Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(web-react): FileUploaderInput className #DS-1508 #1719

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Fix(web-react): FileUploaderInput className #DS-1508 #1719

merged 2 commits into from
Oct 23, 2024

Conversation

curdaj
Copy link
Contributor

@curdaj curdaj commented Oct 17, 2024

Description

Additional context

Issue reference

@netlify Netlify
Copy link

netlify bot commented Oct 17, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 8aa78d8
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/671789df1e64a8000885a22d
😎 Deploy Preview https://deploy-preview-1719--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🟢 up 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 90 (🟢 up 8 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Oct 17, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 8aa78d8
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/671789df329ee20008fa2046

@github-actions github-actions bot added the bug Something isn't working label Oct 17, 2024
@curdaj curdaj marked this pull request as ready for review October 18, 2024 07:21
@curdaj curdaj requested review from literat, pavelklibani and a team as code owners October 18, 2024 07:21
literat
literat approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@curdaj curdaj force-pushed the fix/ds-1508-className-fileUploaderInput branch from d909645 to 8aa78d8 Compare October 22, 2024 11:17
literat
literat approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job 👍

@curdaj curdaj merged commit 3c76287 into main Oct 23, 2024
17 checks passed
@curdaj curdaj deleted the fix/ds-1508-className-fileUploaderInput branch October 23, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crishpeen crishpeen crishpeen approved these changes

@literat literat literat approved these changes

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani is a code owner

Assignees

@curdaj curdaj

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curdaj @literat @crishpeen