Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(exporter-tokens): Add mixin css-variables to theme colors #DS-1542 #1741

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Feat(exporter-tokens): Add mixin css-variables to theme colors #DS-1542 #1741

merged 1 commit into from
Nov 7, 2024

Conversation

curdaj
Copy link
Contributor

@curdaj curdaj commented Nov 4, 2024

Description

Additional context

Issue reference

@github-actions github-actions bot added the feature New feature or request label Nov 4, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 4, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit a94fee7
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/672ce040ba65ef0008f49668
😎 Deploy Preview https://deploy-preview-1741--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 4, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit a94fee7
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/672ce0403de80a00084ea03d

@curdaj curdaj force-pushed the feat/ds-1542-mixin-to-theme-colors branch from 76b007a to d63c22f Compare November 5, 2024 15:11
@curdaj curdaj marked this pull request as ready for review November 5, 2024 15:16
@curdaj curdaj requested review from literat, crishpeen, pavelklibani and a team as code owners November 5, 2024 15:16
@curdaj curdaj changed the title 🚧 Feat(exporter-tokens): Add mixin css-variables to theme colors #DS-1542 Feat(exporter-tokens): Add mixin css-variables to theme colors #DS-1542 Nov 5, 2024
literat
literat approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@curdaj curdaj force-pushed the feat/ds-1542-mixin-to-theme-colors branch from 8163f86 to f2ca6c0 Compare November 7, 2024 09:44
@curdaj curdaj force-pushed the feat/ds-1542-mixin-to-theme-colors branch from d2ac262 to b7346b0 Compare November 7, 2024 14:45
crishpeen
crishpeen approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@curdaj curdaj force-pushed the feat/ds-1542-mixin-to-theme-colors branch from 98c94c1 to a94fee7 Compare November 7, 2024 15:43
@curdaj curdaj merged commit 6b79489 into main Nov 7, 2024
20 checks passed
@curdaj curdaj deleted the feat/ds-1542-mixin-to-theme-colors branch November 7, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelklibani pavelklibani pavelklibani approved these changes

@crishpeen crishpeen crishpeen approved these changes

@literat literat literat approved these changes

Assignees

@curdaj curdaj

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@curdaj @literat @crishpeen @pavelklibani