-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(exporter-tokens): Export only Theme tokens collection #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelklibani
requested review from
literat,
crishpeen,
curdaj and
a team
as code owners
November 6, 2024 12:29
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
literat
reviewed
Nov 6, 2024
literat
reviewed
Nov 6, 2024
literat
reviewed
Nov 6, 2024
literat
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
curdaj
force-pushed
the
feat/ds-1542-mixin-to-theme-colors
branch
3 times, most recently
from
November 7, 2024 15:43
98c94c1
to
a94fee7
Compare
pavelklibani
force-pushed
the
feat/ds-1543-exporter-collections
branch
2 times, most recently
from
November 8, 2024 13:15
40ea6f4
to
979ce6c
Compare
curdaj
approved these changes
Nov 8, 2024
literat
reviewed
Nov 9, 2024
pavelklibani
force-pushed
the
feat/ds-1543-exporter-collections
branch
2 times, most recently
from
November 11, 2024 08:34
e911cc4
to
aabb4bd
Compare
- Filter out primitives from the generated tokens and leave only color theme tokens - solves #DS-1543
pavelklibani
force-pushed
the
feat/ds-1543-exporter-collections
branch
from
November 11, 2024 08:35
aabb4bd
to
a1847f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
TODO:
Issue reference
Exporter | export only colors from collection called
Theme tokens