Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(exporter-tokens): Export only Theme tokens collection #1743

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Nov 6, 2024

Description

Additional context

TODO:

  • Tests

Issue reference

Exporter | export only colors from collection called Theme tokens

@pavelklibani pavelklibani requested review from literat, crishpeen, curdaj and a team as code owners November 6, 2024 12:29
@github-actions github-actions bot added the feature New feature or request label Nov 6, 2024
Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit a1847f5
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6731c1bb3e247400089c9448
😎 Deploy Preview https://deploy-preview-1743--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pavelklibani pavelklibani marked this pull request as draft November 6, 2024 12:30
Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit a1847f5
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6731c1bbce53230008e9f273

@pavelklibani pavelklibani marked this pull request as ready for review November 6, 2024 14:09
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@curdaj curdaj force-pushed the feat/ds-1542-mixin-to-theme-colors branch 3 times, most recently from 98c94c1 to a94fee7 Compare November 7, 2024 15:43
Base automatically changed from feat/ds-1542-mixin-to-theme-colors to main November 7, 2024 15:48
@pavelklibani pavelklibani force-pushed the feat/ds-1543-exporter-collections branch 2 times, most recently from 40ea6f4 to 979ce6c Compare November 8, 2024 13:15
exporters/tokens/src/helpers/colorHelper.ts Outdated Show resolved Hide resolved
@pavelklibani pavelklibani force-pushed the feat/ds-1543-exporter-collections branch 2 times, most recently from e911cc4 to aabb4bd Compare November 11, 2024 08:34
- Filter out primitives from the generated tokens and leave only color theme tokens

- solves #DS-1543
@pavelklibani pavelklibani force-pushed the feat/ds-1543-exporter-collections branch from aabb4bd to a1847f5 Compare November 11, 2024 08:35
@pavelklibani pavelklibani merged commit 3f224f1 into main Nov 11, 2024
20 checks passed
@pavelklibani pavelklibani deleted the feat/ds-1543-exporter-collections branch November 11, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants