Fix(web-react): Pass aria props rel and target based on element type to the dom element #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
literat
requested review from
pavelklibani,
curdaj and
a team
as code owners
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
literat
force-pushed
the
fix/web-react-button-link-aria-props
branch
from
0aaa2f8 to
a9e8472
Compare
literat
commented
Nov 26, 2024
packages/web-react/src/components/ButtonLink/__tests__/useButtonLinkAriaProps.test.ts
Outdated
Show resolved
Hide resolved
pavelklibani
approved these changes
Nov 26, 2024
literat
changed the title
literat
force-pushed
the
fix/web-react-button-link-aria-props
branch
from
a9e8472 to
bf0dcc7
Compare
curdaj
approved these changes
Nov 27, 2024
literat
force-pushed
the
fix/web-react-button-link-aria-props
branch
from
bf0dcc7 to
022d0a3
Compare
…to the dom element refs #DS-1575
literat
force-pushed
the
fix/web-react-button-link-aria-props
branch
from
022d0a3 to
7f146e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
elementTypeprop was not passed to theuseButtonLinkAriaPropshook and this attributes likerelandtargetwere overridden byundefinedvalue. So those could never reach the DOM element.Additional context
Issue reference