Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore(demo): Hide elements in Supernova component preview #1779

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Chore(demo): Hide elements in Supernova component preview #1779

merged 1 commit into from
Nov 27, 2024

Conversation

curdaj
Copy link
Contributor

@curdaj curdaj commented Nov 26, 2024

Description

Additional context

Issue reference

@github-actions github-actions bot added the bug Something isn't working label Nov 26, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 26, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit aa302ec
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67472bbfa027090008b09a74

@netlify Netlify
Copy link

netlify bot commented Nov 26, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit aa302ec
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67472bbf546df400084cac1b
😎 Deploy Preview https://deploy-preview-1779--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

literat
literat reviewed Nov 26, 2024
View reviewed changes
apps/demo/netlify.toml Outdated Show resolved Hide resolved
@curdaj curdaj force-pushed the fix/handling-corse-in-netlify branch 3 times, most recently from a44e74a to fb62e00 Compare November 27, 2024 13:47
@curdaj curdaj marked this pull request as ready for review November 27, 2024 13:51
@curdaj curdaj requested a review from a team as a code owner November 27, 2024 13:51
@curdaj curdaj force-pushed the fix/handling-corse-in-netlify branch from fb62e00 to 6f6b37d Compare November 27, 2024 13:54
@curdaj curdaj changed the title Chore: Handling CORS on Netlify Chore(demo): Hide elements in Supernova component preview Nov 27, 2024
@curdaj curdaj force-pushed the fix/handling-corse-in-netlify branch from 6f6b37d to eababba Compare November 27, 2024 14:19
@curdaj curdaj force-pushed the fix/handling-corse-in-netlify branch from eababba to aa302ec Compare November 27, 2024 14:25
@curdaj curdaj merged commit f496c5a into main Nov 27, 2024
20 checks passed
@curdaj curdaj deleted the fix/handling-corse-in-netlify branch November 27, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat literat approved these changes

Assignees

@curdaj curdaj

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curdaj @literat