Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test(web-react): Mock usage of the useIcon hook #1803

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Conversation

literat
Copy link
Collaborator

@literat literat commented Dec 9, 2024

Description

  • so we get rid of the console.warn messages in our tests
  • when testing our components without using the IconsProvider

Additional context

Issue reference

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit e88ca5d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67586d9c950fd200081bb5a9
😎 Deploy Preview https://deploy-preview-1803--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit e88ca5d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67586d9c4700a10008142d37
😎 Deploy Preview https://deploy-preview-1803--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@literat literat force-pushed the test/fix-console-warns branch from 6edc88b to b1e1364 Compare December 10, 2024 16:33
  * so we get rid of the `console.warn` messages in our tests
  * when testing our components without using the `IconsProvider`
@literat literat force-pushed the test/fix-console-warns branch from b1e1364 to e88ca5d Compare December 10, 2024 16:34
@literat literat merged commit 9f99b21 into main Dec 10, 2024
23 checks passed
@literat literat deleted the test/fix-console-warns branch December 10, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants