Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs(web-react): Add more info about GridItem attributes #1806

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Docs(web-react): Add more info about GridItem attributes #1806

merged 3 commits into from
Dec 16, 2024

Conversation

pavelklibani
Copy link
Contributor

Description

Additional context

Issue reference

GridItem: Rozepsat používání atribut v komponentě GridItem

@pavelklibani pavelklibani self-assigned this Dec 10, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 10, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 10, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 63c26f2
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/676069ac8c6d2300080f3199
😎 Deploy Preview https://deploy-preview-1806--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 10, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 63c26f2
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/676069ac24a5d2000809e7c8
😎 Deploy Preview https://deploy-preview-1806--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@literat literat requested a review from dlouhak December 10, 2024 17:28
@literat
Copy link
Collaborator

literat commented Dec 10, 2024

@dlouhak I am adding you to this PR because the feedback for this issue came from you. So please, feel free to suggest changes so the documentation will be clearer for the devs. Thanks a lot :-)

@pavelklibani pavelklibani marked this pull request as ready for review December 11, 2024 20:49
@pavelklibani pavelklibani requested review from literat, curdaj and a team as code owners December 11, 2024 20:49
@pavelklibani pavelklibani force-pushed the docs/ds-1032-griditem-attributes branch from c09f996 to b727e3f Compare December 12, 2024 09:09
@coveralls
Copy link

coveralls commented Dec 12, 2024 •
edited
Loading

Coverage Status

coverage: 79.469%. remained the same
when pulling 63c26f2 on docs/ds-1032-griditem-attributes
into 44eb2e1 on main.

@pavelklibani pavelklibani force-pushed the docs/ds-1032-griditem-attributes branch 5 times, most recently from 2cda6cd to dddeeb1 Compare December 12, 2024 12:48
@dlouhak
Copy link
Contributor

dlouhak commented Dec 12, 2024

Thank you! ❤️

I've only got a small question: shouldn't this also be documented in the Web and Web Twig packages? Or only in the Web package, and React with Twig should have a reference to it.

@literat
Copy link
Collaborator

literat commented Dec 12, 2024

Thank you! ❤️

I've only got a small question: shouldn't this also be documented in the Web and Web Twig packages? Or only in the Web package, and React with Twig should have a reference to it.

🙈 You are right. The issue has also spirit-web and spirit-web-twig labels. @pavelklibani

literat
literat requested changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add this also to web and web-twig packages.

@pavelklibani pavelklibani force-pushed the docs/ds-1032-griditem-attributes branch from dddeeb1 to 96c96f4 Compare December 13, 2024 08:34
@pavelklibani pavelklibani force-pushed the docs/ds-1032-griditem-attributes branch from 96c96f4 to c4548be Compare December 13, 2024 08:36
@pavelklibani pavelklibani requested a review from literat December 13, 2024 08:37
literat
literat approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks 👍

@pavelklibani pavelklibani force-pushed the docs/ds-1032-griditem-attributes branch from c4548be to 63c26f2 Compare December 16, 2024 17:55
@pavelklibani pavelklibani merged commit 1676c2d into main Dec 16, 2024
35 checks passed
@pavelklibani pavelklibani deleted the docs/ds-1032-griditem-attributes branch December 16, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlouhak dlouhak dlouhak left review comments

@curdaj curdaj curdaj approved these changes

@crishpeen crishpeen crishpeen approved these changes

@literat literat literat approved these changes

@adamkudrna adamkudrna Awaiting requested review from adamkudrna adamkudrna is a code owner

Assignees

@pavelklibani pavelklibani

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pavelklibani @literat @coveralls @dlouhak @crishpeen @curdaj