-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(web-react): Use @local/tests
path alias in tests
#1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
refactoring
A code change that neither fixes a bug nor adds a feature
label
Dec 10, 2024
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
literat
commented
Dec 10, 2024
packages/web-react/src/components/Accordion/__tests__/Accordion.test.tsx
Show resolved
Hide resolved
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
literat
commented
Dec 10, 2024
literat
commented
Dec 10, 2024
literat
force-pushed
the
refactor/tests-import-alias
branch
from
December 17, 2024 12:19
a8ac61a
to
8be5e9c
Compare
literat
commented
Dec 17, 2024
literat
force-pushed
the
refactor/tests-import-alias
branch
from
December 17, 2024 16:51
26e8293
to
a12fbac
Compare
literat
requested review from
pavelklibani,
curdaj and
a team
as code owners
December 17, 2024 16:57
literat
force-pushed
the
refactor/tests-import-alias
branch
from
December 19, 2024 12:36
0ff16c0
to
81873fb
Compare
literat
force-pushed
the
refactor/tests-import-alias
branch
from
December 19, 2024 12:49
81873fb
to
fa7e713
Compare
pavelklibani
approved these changes
Dec 19, 2024
pavelklibani
approved these changes
Dec 19, 2024
literat
force-pushed
the
refactor/tests-import-alias
branch
2 times, most recently
from
December 21, 2024 20:09
1d835a6
to
88ddb8c
Compare
…ock between tests
literat
force-pushed
the
refactor/tests-import-alias
branch
from
December 30, 2024 17:16
88ddb8c
to
5aff4cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tests
directory@local/tests
path alias - tsconfig + ESlintuseIcon
mock because of path changes and crazy Jest and JavaScript mock hoistingdata-testId
->data-testid
Additional context
I suggest doing a review per commit. The settings themselves are in different commits than changes in test files.
Issue reference
https://jira.almacareer.tech/browse/DS-1611
https://jira.almacareer.tech/browse/DS-1612