Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore(ci): Check for the clean working directory after the build #1821

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Chore(ci): Check for the clean working directory after the build #1821

merged 1 commit into from
Dec 17, 2024

Conversation

literat
Copy link
Collaborator

@literat literat commented Dec 16, 2024

Description

  • we sometimes forget to built and commit an exporter build
  • this stops the publishing of the packages because of a dirty working directory

Additional context

Issue reference

@literat literat requested a review from a team as a code owner December 16, 2024 10:56
@github-actions github-actions bot added the maintenance Changes to the build process or auxilary tools and libraries or other maintenance label Dec 16, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 16, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 84c0d28
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67614d341dfaf10009784fa7
😎 Deploy Preview https://deploy-preview-1821--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 16, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 84c0d28
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67614d3490803e0008497628

crishpeen
crishpeen approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

@literat
Chore(ci): Check for the clean working directory after the build
84c0d28 
  * we sometimes forget to built and commit an exporter build
  * this stops publishing of the packages because of dirty working directory
@literat literat force-pushed the chore/clean-working-dir-after-build branch from 878dd5f to 84c0d28 Compare December 17, 2024 10:06
@coveralls
Copy link

Coverage Status

coverage: 79.469%. remained the same
when pulling 84c0d28 on chore/clean-working-dir-after-build
into 1676c2d on main.

@literat literat merged commit 724b9ba into main Dec 17, 2024
29 checks passed
@literat literat deleted the chore/clean-working-dir-after-build branch December 17, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crishpeen crishpeen crishpeen approved these changes

Assignees

@literat literat

Labels
maintenance Changes to the build process or auxilary tools and libraries or other maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@literat @coveralls @crishpeen