Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add Info about file size in FileUploader #DS-993 #1822

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Dec 16, 2024

Description

The primary update is in the React README, which is now referenced by other packages.

  • Added an example demonstrating how to calculate file size.
  • Clarified the distinction between the base-10 and base-2 systems.
  • Included examples for PHP and Next.js configurations, along with their shorthands.

Additional context

Issue reference

FileUploader: file size limit dokumentace

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 16, 2024
Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit c984eeb
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67640fe0de2b42000812f400
😎 Deploy Preview https://deploy-preview-1822--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit c984eeb
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67640fe02c06f000088cc13d
😎 Deploy Preview https://deploy-preview-1822--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Dec 16, 2024

Coverage Status

coverage: 79.469%. remained the same
when pulling 685a5d8 on docs/ds-993-fileuploader-file-size-limit
into 1676c2d on main.

@pavelklibani pavelklibani force-pushed the docs/ds-993-fileuploader-file-size-limit branch from 0f58a14 to be3f93f Compare December 16, 2024 18:40
@literat literat requested a review from vaclavbarta December 17, 2024 08:16
@pavelklibani pavelklibani force-pushed the docs/ds-993-fileuploader-file-size-limit branch from 685a5d8 to 718213f Compare December 17, 2024 12:02
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely documented. I love it. Thanks :-)

Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astonishing and valuable. I learned something new today, thank you!

@pavelklibani pavelklibani force-pushed the docs/ds-993-fileuploader-file-size-limit branch from 0be75be to c984eeb Compare December 19, 2024 12:21
@pavelklibani pavelklibani merged commit 035a612 into main Dec 19, 2024
35 checks passed
@pavelklibani pavelklibani deleted the docs/ds-993-fileuploader-file-size-limit branch December 19, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants