-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(web-react): Additional parameter for styleProps and Box refactor #1831
base: feat/ds-1595-box-component
Are you sure you want to change the base?
Feat(web-react): Additional parameter for styleProps and Box refactor #1831
Conversation
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
f30ecd6
to
5d781e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can we add this to the Footer somehow as well (but limited to only top and bottom)? Or do you plan to do this in a separate issue/PR?
My only concern was padding="auto"
, which we shouldn't allow, but we discussed it on Slack.
3e5dcb7
to
dc0fb7f
Compare
5d781e9
to
ae97ce3
Compare
ae97ce3
to
0b2e6ba
Compare
Footer refactored (separate commit). We discussed the |
Description
Additional context
Issue reference