Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web-react): Additional parameter for styleProps and Box refactor #1831

Open
wants to merge 2 commits into
base: feat/ds-1595-box-component
Choose a base branch
from

Conversation

curdaj
Copy link
Contributor

@curdaj curdaj commented Dec 23, 2024

Description

Additional context

Issue reference

@github-actions github-actions bot added the feature New feature or request label Dec 23, 2024
Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 800c454
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6773d4303fd33e00084be48c
😎 Deploy Preview https://deploy-preview-1831--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 800c454
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6773d43079f1ff00080fd596
😎 Deploy Preview https://deploy-preview-1831--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@curdaj curdaj force-pushed the feat/additional-parameter-styleProps branch from f30ecd6 to 5d781e9 Compare December 27, 2024 12:23
@curdaj curdaj marked this pull request as ready for review December 30, 2024 08:57
@curdaj curdaj requested review from literat, pavelklibani and a team as code owners December 30, 2024 08:57
Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we add this to the Footer somehow as well (but limited to only top and bottom)? Or do you plan to do this in a separate issue/PR?

My only concern was padding="auto", which we shouldn't allow, but we discussed it on Slack.

@curdaj curdaj force-pushed the feat/ds-1595-box-component branch from 3e5dcb7 to dc0fb7f Compare December 31, 2024 10:19
@curdaj curdaj requested a review from adamkudrna as a code owner December 31, 2024 10:19
@curdaj curdaj force-pushed the feat/additional-parameter-styleProps branch from 5d781e9 to ae97ce3 Compare December 31, 2024 11:04
@curdaj curdaj force-pushed the feat/additional-parameter-styleProps branch from ae97ce3 to 0b2e6ba Compare December 31, 2024 11:05
@curdaj
Copy link
Contributor Author

curdaj commented Dec 31, 2024

LGTM, can we add this to the Footer somehow as well (but limited to only top and bottom)? Or do you plan to do this in a separate issue/PR?

My only concern was padding="auto", which we shouldn't allow, but we discussed it on Slack.

Footer refactored (separate commit).

We discussed the padding="auto". It is type-checked and must be of the SpaceToken type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants