Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web): Introduce button-unstyled helper #1838

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@github-actions github-actions bot added the feature New feature or request label Jan 8, 2025
Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 906ea88
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/678678286275f000089bbe36
😎 Deploy Preview https://deploy-preview-1838--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 906ea88
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/678678288d277f000873d492
😎 Deploy Preview https://deploy-preview-1838--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@crishpeen crishpeen force-pushed the feature/dropdown-alignment branch from a43b7c7 to a500b28 Compare January 8, 2025 14:02
@crishpeen crishpeen force-pushed the feature/unstyled-button branch from b6e3892 to 14ebbb7 Compare January 8, 2025 14:03
@coveralls
Copy link

coveralls commented Jan 8, 2025

Coverage Status

coverage: 79.469%. remained the same
when pulling 906ea88 on feature/unstyled-button
into c4200ad on integration/header.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discused personally. I think we will be working more on the Buttons in the future.

Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@crishpeen crishpeen force-pushed the feature/dropdown-alignment branch 2 times, most recently from 22e2b02 to 4204135 Compare January 14, 2025 14:35
Base automatically changed from feature/dropdown-alignment to integration/header January 14, 2025 14:42
@crishpeen crishpeen force-pushed the feature/unstyled-button branch from 14ebbb7 to 906ea88 Compare January 14, 2025 14:43
@crishpeen crishpeen merged commit 3579c8e into integration/header Jan 14, 2025
29 checks passed
@crishpeen crishpeen deleted the feature/unstyled-button branch January 14, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants