Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved the metadata into setup.cfg #382

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KOLANICH
Copy link

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.8% when pulling 6c05df9 on KOLANICH:setup.cfg into 4599459 on lmcinnes:master.

@lmcinnes
Copy link
Owner

lmcinnes commented Mar 27, 2020

Thanks! I admit that I am not very good at the whole packaging thing, so I'm happy to just get stuff to work at all usually. I definitely appreciate work that can make this more efficient and maintainable (and up to date with modern methods for doing these things).

I note that the version information has disappeared -- how does that get handled with this?

@sleighsoft
Copy link
Collaborator

sleighsoft commented Mar 31, 2020

I think the dependency setuptools_scm uses git tags to craft version strings. I haven't looked into it too much though.

So if you do git tag 0.4 before you build the wheel, the wheel version will be 0.4. To have programmatic access to the version number (which is not the case in this PR), you could do the following

setup.py

from setuptools import setup

setup(use_scm_version=True)

pyproject.toml

...
[tool.setuptools_scm]
write_to = "umap/_version.py"

Which can then be used by e.g. CLI with

from umap._version import version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants