Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double conversion to date caused invalid date #308

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

dinmukhamedm
Copy link
Member

@dinmukhamedm dinmukhamedm commented Jan 7, 2025

Add a flag to render numeric timestamp to fix the dashboard


Important

Fixes double date conversion in charts by adding numericTimestamp flag to handle numeric timestamps correctly.

  • Behavior:
    • Adds numericTimestamp flag to ChartProps in span-stat-chart.tsx and trace-stat-chart.tsx to handle numeric timestamps.
    • Updates tickFormatter in DefaultLineChart to use formatTimestampFromSecondsWithInterval when numericTimestamp is true.
  • Functions:
    • Modifies DefaultLineChart in span-stat-chart.tsx to support numericTimestamp for correct timestamp formatting.
    • Removes formatTimestampFromSeconds from trace-stat-chart.tsx as it's no longer needed.
  • Misc:
    • Minor refactoring in trace-stat-chart.tsx to pass numericTimestamp to DefaultLineChart.

This description was created by Ellipsis for 48a2e71. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 48a2e71 in 2 minutes and 7 seconds

More details
  • Looked at 80 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/components/dashboard/span-stat-chart.tsx:157
  • Draft comment:
    Consider passing the numericTimestamp prop to the StackedBarChart component to ensure consistent timestamp formatting across different chart types.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_GKwrKARmvGSme0gw


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@dinmukhamedm dinmukhamedm merged commit e86feae into dev Jan 7, 2025
2 checks passed
@dinmukhamedm dinmukhamedm deleted the fix/timestamp branch January 7, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant