fix: double conversion to date caused invalid date #308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a flag to render numeric timestamp to fix the dashboard
Important
Fixes double date conversion in charts by adding
numericTimestamp
flag to handle numeric timestamps correctly.numericTimestamp
flag toChartProps
inspan-stat-chart.tsx
andtrace-stat-chart.tsx
to handle numeric timestamps.tickFormatter
inDefaultLineChart
to useformatTimestampFromSecondsWithInterval
whennumericTimestamp
is true.DefaultLineChart
inspan-stat-chart.tsx
to supportnumericTimestamp
for correct timestamp formatting.formatTimestampFromSeconds
fromtrace-stat-chart.tsx
as it's no longer needed.trace-stat-chart.tsx
to passnumericTimestamp
toDefaultLineChart
.This description was created by for 48a2e71. It will automatically update as commits are pushed.