Skip to content

Commit

Permalink
Auto merge of #117156 - jmillikin:os-unix-socket-ext, r=Amanieu,dtolnay
Browse files Browse the repository at this point in the history
Convert `Unix{Datagram,Stream}::{set_}passcred()` to per-OS traits

These methods are the pre-stabilized API for obtaining peer credentials from an `AF_UNIX` socket, part of the `unix_socket_ancillary_data` feature.

Their current behavior is to get/set one of the `SO_PASSCRED` (Linux), `LOCAL_CREDS_PERSISTENT` (FreeBSD), or `LOCAL_CREDS` (NetBSD) socket options. On other targets the `{set_}passcred()` methods do not exist.

There are two problems with this approach:

1. Having public methods only exist for certain targets isn't permitted in a stable `std` API.

2. These options have generally similar purposes, but they are non-POSIX and their details can differ in subtle and surprising ways (such as whether they continue to be set after the next call to `recvmsg()`).

Splitting into OS-specific extension traits is the preferred solution to both problems.
  • Loading branch information
bors committed Mar 11, 2024
2 parents d4e7b61 + c84d534 commit 72b72e7
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 72b72e7

Please sign in to comment.