Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bin format #1847

Merged
merged 26 commits into from
Oct 9, 2024
Merged

Bin format #1847

merged 26 commits into from
Oct 9, 2024

Conversation

treelin611
Copy link
Collaborator

@treelin611 treelin611 commented Sep 29, 2024

Motivate of the pull request

Describe the technical details

What is currently done?

  • Created libopenfpgacapnproto to implement Cap'n Proto for loading and writing binary files.
  • Added functions to call Cap'n Proto builder and reader for writing to and retrieving information from binary files.
  • Called member functions from device_rr_gsb to load or generate unique block information.

To be checked

  • A careful review of the file structure of libopenfpgacapnproto is needed.
  • libopenfpgacapnproto is copied from libvtrcapnproto and modified.
  • The workflow could be optimized to eliminate redundant steps, as Cap'n Proto is already used in VTR
    image

Copy link
Collaborator

@tangxifan tangxifan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@treelin611 Good work. Minor changes are required.

@treelin611
Copy link
Collaborator Author

treelin611 commented Oct 9, 2024

Here are the main updates:

  1. The auto-generation of the Cap'n Proto file is included in this PR.
  2. I also added a cross-test case to read a binary file and write an XML file. The written XML file is consistent with the one generated using the write_uniqueblocks command with the type set to XML.
  3. The CMakeList.txt file of libopenfpgacapnproto has been cleaned up by linking the libvtrcapnproto library.

Copy link
Collaborator

@Tulong4Dev Tulong4Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Collaborator

@tangxifan tangxifan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangxifan tangxifan merged commit 7c3de4c into master Oct 9, 2024
38 checks passed
@tangxifan tangxifan deleted the bin_format branch October 9, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants