-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add acquisition and analysis scripts #3
Open
juliacscarvalho
wants to merge
8
commits into
master
Choose a base branch
from
add_plots_notebook
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliacscarvalho
requested review from
fernandohds564 and
guilhermerc
and removed request for
fernandohds564
June 27, 2024 13:13
juliacscarvalho
force-pushed
the
add_plots_notebook
branch
from
June 28, 2024 17:28
a0d8fe0
to
662c103
Compare
anacso17
reviewed
Jun 28, 2024
sysid/python_lib/FOFB-analysis.ipynb
Outdated
" prbs[prbs == 0] = -1\n", | ||
" \n", | ||
" acq.params.svd_levels_singmode_idx = data['params']['svd_levels_singmode_idx']\n", | ||
" lvlsx, lvlsy = acq.get_levels_bpms_from_svd(ampmax = acq.params.svd_levels_ampmax*factor, lvl = -val*factor)\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use here the new prbs data (beam order)?
guilhermerc
requested changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider the changes on sysid/python_lib/FOFB-analysis.ipynb
as we discussed.
juliacscarvalho
force-pushed
the
add_plots_notebook
branch
from
September 4, 2024 16:13
5a1ea6c
to
bafdcb0
Compare
guilhermerc
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sysid/python_lib: SysId acquisition and analysis notebooks were added. There is also a script for for Power Spectral Density and RMS Beam Size plots (fofb_exp_plots).