GC-2069: Fix Setting Color to false Produces API Validation Error
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpjones
force-pushed
the
fix/GC-2069-color-cannot-be-set-to-false
branch
2 times, most recently
from
1fa2a62
to
ce93abd
Compare
shannamurry
reviewed
Jan 18, 2024
src/lob.dotnet/Model/Letter.cs
Outdated
| @@ -764,7 +764,7 @@ public IEnumerable<System.ComponentModel.DataAnnotations.ValidationResult> Valid | |||
| } | |||
|
|
|||
| // Url (string) pattern | |||
| Regex regexUrl = new Regex(@"^https:\/\/(lob-assets|lob-assets-staging)\\.com\/(letters|postcards|bank-accounts|checks|self-mailers|cards)\/[a-z]{3,4}_[a-z0-9]{15,16}(\\.pdf|_thumb_[a-z]+_[0-9]+\\.png)\\?(version=[a-z0-9-]*&)?expires=[0-9]{10}&signature=[a-zA-Z0-9-_]+$", RegexOptions.CultureInvariant); | |||
| Regex regexUrl = new Regex(@"^https:\/\/lob-assets.com\/(letters|postcards|bank-accounts|checks|self-mailers|cards)\/[a-z]{3,4}_[a-z0-9]{15,16}('|_signature)(.pdf|_thumb_[a-z]+_[0-9]+.png|.png)?(version=[a-z0-9]*&)expires=[0-9]{10}&signature=[a-zA-Z0-9-_]+", RegexOptions.CultureInvariant); | |||
There was a problem hiding this comment.
It should have been omitted from the changes, let me fix that
shannamurry
approved these changes
Jan 18, 2024
kevinpjones
force-pushed
the
fix/GC-2069-color-cannot-be-set-to-false
branch
from
ce93abd
to
a7b2083
Compare
kevinpjones
force-pushed
the
fix/GC-2069-color-cannot-be-set-to-false
branch
from
a7b2083
to
4a1056b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.