-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/466 autosave #485
base: 2.x
Are you sure you want to change the base?
Feature/466 autosave #485
Conversation
Initial look through. |
@andybroomfield If you don't select any of the content types, it defaults to being enabled for all content types. So I don't think that would require ongoing changes. |
Would be good to have a notification or something to existing sites via We've lots of nice new features that existing sites don't get by default. Sorry, I know this is a side issue to the main PR. |
No need to apologise Mark, this was a large topic of conversation in our Tech Group Governance meeting yesterday. Specifically: "What is the policy for adding modules to default install LocalGov eg. autosave" I will draft a policy for review, but key questions include:
So perhaps we can use this pull request as a case in point to draft and agree a working policy for such things. |
Thanks @keelanfh I did notice that after a while, I got thrown as autosave does not work for /node/add, so only noticed it when I went back to edit. |
Worth putting this to draft whilst the discussion is ongoing @finnlewis ? |
I've started a draft policy for discussion on the general questions this raises: https://github.com/localgovdrupal/localgov/wiki/%5BDraft%5D-Policy-for-adding-a-new-feature,-functionality-or-modules-to-LocalGov-Drupal |
@andybroomfield that's interesting that it doesn't work for /node/add, I was not aware of that. |
Going to need at least these patches on core I think to get it to work with paragraphs And this patch on the module to get autosave on node creation |
This is still being discussed in the backlog group with some updates being tested. |
Still being discussed #466 |
@keelanfh @markconroy @andybroomfield
Here's a PR to test, just adds and installs the module with default configuration (saves content forms every 60 seconds)
Coming from #466