1.8.x Refactor #338
1.8.x Refactor #338
Conversation
…-type-fixes fix: additional strict type fixes
Fix #323 Refactor the alert banner entitiy to use a more standard approach to revisions, using \Drupal\Core\Entity\Routing\RevisionHtmlRouteProvider instead of custom routes, and using standard revsion routes instead of custom versions in routing.yml. This also groups all the none view crud permissions into the manage alert banner permission in alertBannerEntityAccessControlHandler.
Normally not required as the view is in place, but sometimes needed if the view is disabled.
Note: this may still get removed later in the refactor, but for now restore route admin/structure/alert-banner-types
Ref #334 Flaged as deprecated because of the {% spaceless %} tag, which should have been removed with the move to Drupal 9? However this template is simply not used, so removing.
Ref #334 Remove view default_argument_skip_url config key which is being removed. See https://www.drupal.org/node/3382316
Fix #261 Use a new AlertBannerManager service and move the getCurentBanners method from the block to the manager service. Adds an $options array for setting the type and future options. Small refactor to use loadMultiple.
…ctor Initial refactor of revision provider and access
Remove unused add type template
…anager Move getCurrentBanners to a service
Run tests on 1.8.x branch
…fault-argument Remove default_argument_skip_url from group manage alert banners view
Fix #229 Implements hook_gin_content_form_routes for both the alert banner creation and edit form. This makes editing the alert banner like nodes. Renames the publishing options group meta to auto pick up gin theming. Moves the revision log and new revision into the meta group Add a flag if this is the Gin theme, if it is add the extra class to meta so it is themed like nodes.
Fix #342 Use the standard drupal paths (entity_type/manage) for the alert banner entity type routes, and add a local task for the edit link. This restores expected behaviour with edit, fields, manage form, manage display, permissions. Remove unneed entity type route provider and remove todo comment from entity type list builder.
…theme Opt into the Gin content form routes (edit theme)
…entity-type Fix alert banner entity type paths and local tasks
…ermissions-test Fix routes to localgov_alert_banner_types in permissions test
Fix #271 Small refactor to remove the js-cookie dependancy by using native javascript cookie read and write methods.
|
Suggest re rename this branch becuase having a 1.8.x branch seems to be the root of the test failures. |
|
and yet renaming this branch causes this one to pass? |
Remove js-cookie dependancy
Split on `; ` instead of just `;`
Replacing js-cookie functionality with native Javascript.
…ository) (#369) * Deprecate old constructor signiture of alert banner block This may not be totally nescerry, but to be on the safe side in case the block has been extended, this deprecates the old signiture with current_user and entity.repository and marks alert banner manager as required. * Add the deprecatedProperttTrait to the alert banner block Allows block extensions to still have a currentUser and entityRepository
Fix #247 This provides the details in the readme, will open a new issue for the config option.
See #327. Extends visibility test by providing actual pages for the banner to display on. This also provides an extra banner to test the correct banner is visible per page.
…ble-check Move the visible check to alert banner manager
What does this change?Refactors the Alert banner entity, alert banner block and adds an alert banner manager service. How to test
How can we measure success?Alert banner should function as before, now with Drupal 11 support and the deperacation warnings should be gone. Have we considered potential risks?Check that refactor does not have any side effects. Imagesn/a Accessibilityn/a (follow up PRs to be added in 1.8.1) |
…s-from-drupal-coder-update fix: coding standards introduced by latest drupal coder rules
This fixes issue where alert banner cookie shows again even though it was hidden
|
@andybroomfield I've tested this on Drupal 10 / localgov 3.x and all functionality seems to work as smoothly as ever. Now trying to test on Drupal 11, although we're not explicitly testing again Drupal 11 yet and I imagine it will be a while until many people are using Drupal 11. |
|
How are you installing localgov Drupal 11 @andybroomfield ? I'm trying this : But then getting composer issues. |
|
Hey @finnlewis yeah profile blocks the install currently from that branch as it's very experimental. I've been installing the 3.x branch and upgrading to D11 and testing |
Thanks @millnut - can you point me in the right direction with some quick steps to upgrade to D11? |
|
Meanwhile, @andybroomfield , tested on a vanilla Drupal 11 install, and it installs and functions well. The only thing I notice is that
I guess for now we are targeting people who are installing this as part of LocalGov Drupal, so perhaps that's something for the future? |
|
@finnlewis Yes, I've been thinking of providing an olivero block, and then the localgov theme blocks could use the method @rupertj is / has created. |
Feature/378/remove polyfills
|
Just a note, I've added @markconroy PR on removing polyfills to this PR also. Apolgies if that means you need to restart testing. |
Current blockers
Propose we handle in patch release as needs more discussion
Don't know