1.8.3 release #400
Merged
1.8.3 release #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removes jQuery, adds modern (Drupal) JS * adds once library as a dependency * waits for button to be present before clicking it * Remove DomcontentLoaded event Since javascript is already in Drupal behaviours attach function, the dom should already be present. Once behaviours should prevent multiple attachments Moved the setAlertBannerHideCookie function outside the attach. * CS: test fixes * Restore find button by contents in alertbannerhidetest * Add core/drupal and core/once dependencies Fix tests and use of alert banner on themes that don't use the once in the theme. The new javascript no longer requires jQuery, but does require the use of the core/drupal and core/once libraries in order to function. These are provided by most themes, but not stark or stable9 which the tests run with. Should also resolve any issues we have with forthcoming javascript library changes. See: https://www.drupal.org/node/3473558 Asset ordering is now more strictly determined by library dependencies --------- Co-authored-by: Andy Broomfield <[email protected]>
Add a default block for the olivero theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.