Auto fix of linting issues #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref #399 Apply auto fixes to alert banner js files using ``` npx eslint@8 --ext .js --resolve-plugins-relative-to=./web/core --fix web/modules/contrib/localgov_alert_banner ```
Ref #399 Fixed using ``` npx eslint@8 --ext .yml --resolve-plugins-relative-to=./web/core --fix web/modules/contrib/localgov_alert_banner ```
Ref #399 Fixed with following command ``` npx stylelint --ignore-path web/core/.stylelintignore --config web/core/.stylelintrc.json --fix web/modules/contrib/localgov_alert_banner/**/*.css ```
ekes
approved these changes
Jan 20, 2025
Adnan-cds
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #399
What does this change?
Apply auto fixes to alert banner js files using
How to test
ESLint tests will now pass (Javascript has 3 warnings)
How can we measure success?
Tests pass and banner still works as expected.
Have we considered potential risks?
Need to make sure we test for any breaks