Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default colours for subsites extras #551

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

markconroy
Copy link
Member

@markconroy markconroy commented May 29, 2024

Closes #550

Default is now:

  1. Background colour of region: accent
  2. Background colour of menu items: white
  3. Colour of menu items text: accent
  4. Border on menu items: white

(Basically, the opposite of what we had.)

Screenshot 2024-05-29 at 15 30 47

===
Thanks to Big Blue Door for sponsoring my time to work on this.

@willguv
Copy link
Member

willguv commented May 29, 2024

Can you add a screenshot please @markconroy cheers. Thanks for looking at this so quickly

@markconroy
Copy link
Member Author

@willguv screenshot added above just now

@finnlewis
Copy link
Member

@willguv would like to discuss the menu items looking like buttons. Potentially want a slightly different approach for subsites extras menus.

@willguv
Copy link
Member

willguv commented Jun 11, 2024

@markconroy is it easy to make it look like this out of the box?

https://new.dumgal.gov.uk/gretna-registration-office/your-wedding-ceremony

Screenshot 2024-06-11 at 12 32 21 Screenshot 2024-06-11 at 12 32 28

@markconroy
Copy link
Member Author

@willguv Some updates:

  1. Default state - no background colour on menu links
  2. Hover state - white background, with link underlined
  3. Active trail state - white background, no underline, menu tab merges with white section of page below it

All the variables we created are still there so easy to have any style you want, and some new variables have been created to make this even more flexible.

Default:

Screenshot 2024-06-14 at 09 47 08

Hover:

Screenshot 2024-06-14 at 09 47 20

Active:

Screenshot 2024-06-14 at 09 47 29

@willguv
Copy link
Member

willguv commented Jun 14, 2024

That's spot on, thanks @markconroy!

@markconroy markconroy merged commit 3284fc6 into 1.x Jun 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set subsite menu colors to dark with light text
4 participants