Fix/580/alert banner dialog #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybroomfield
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Working for me, thanks @markconroy
One thing to note is the change in ::backdrop behaviour, which means in pre Chrome 122 it does not inherit the custom properties declared in variables.css so I see no background colour (fine in Firefox and edge and assume my Chomre when it updates).
Chrome 120:
Firefox:
Merge back to fix branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #580
See notes: localgovdrupal/localgov_alert_banner#360
Thanks to Big Blue Door for sponsoring my time to work on this.