Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tabindex -1 to skip link target #589

Merged

Conversation

anthonylindsay
Copy link
Contributor

##What does this change?

Adds tabindex="-1" to <main>.

This is for an IOS/keyboard navigation bug which means focus never really gets to main content when using the skip link, and keyboard-navigation IOS users effectively cannot use the skip link.

It allows focus the main content element.

How to test

This is primarily only testable with the correct hardware: an IOS device & external keyboard.

  1. Load a page.
  2. Navigate to the skip link
  3. Hit ENTER to activate it.
  4. Verify that you have been brought to the main content area (i.e. past main nav/header)
  5. Hit TAB again.
  6. Verify that focus is now on the next available link or focusable element within main content.

@markconroy markconroy merged commit 8c73c11 into localgovdrupal:1.x Aug 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants