Uses logical properties for fields.css file #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @markconroy this is the error from the test, I wonder whether this branch was created when the helper was in 1.x, and since it's been reverted this branch needs to be rebased? PHPUnit 9.6.21 by Sebastian Bergmann and contributors.
Testing /app/web/themes/contrib/localgov_base
ER 2 / 2 (100%)E
Time: 02:33.901, Memory: 10.00 MB
There were 2 errors:
1) Drupal\Tests\block_content\Functional\RegionRenderTest::testRegionRender with data set #0 ('disabled', 'FALSE')
Drupal\Core\Extension\MissingDependencyException: Unable to install theme: 'localgov_base' due to unmet module dependencies: 'localgov_base_helper'.
/app/web/core/lib/Drupal/Core/Extension/ThemeInstaller.php:176
/app/web/core/includes/install.core.inc:1654
/app/web/core/includes/install.core.inc:695
/app/web/core/includes/install.core.inc:572
/app/web/core/includes/install.core.inc:121
/app/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:315
/app/web/core/tests/Drupal/Tests/BrowserTestBase.php:570
/app/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/app/vendor/phpunit/phpunit/src/Framework/TestResult.php:729
2) Drupal\Tests\block_content\Functional\RegionRenderTest::testRegionRender with data set #1 ('sidebar_first', 'TRUE')
Drupal\Core\Extension\MissingDependencyException: Unable to install theme: 'localgov_base' due to unmet module dependencies: 'localgov_base_helper'.
/app/web/core/lib/Drupal/Core/Extension/ThemeInstaller.php:176
/app/web/core/includes/install.core.inc:1654
/app/web/core/includes/install.core.inc:695
/app/web/core/includes/install.core.inc:572
/app/web/core/includes/install.core.inc:121
/app/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:315
/app/web/core/tests/Drupal/Tests/BrowserTestBase.php:570
/app/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/app/vendor/phpunit/phpunit/src/Framework/TestResult.php:729
--
There was 1 risky test:
1) Drupal\Tests\block_content\Functional\RegionRenderTest::testRegionRender with data set #0 ('disabled', 'FALSE')
This test did not perform any assertions
/app/web/core/tests/Drupal/Tests/Listeners/DrupalListener.php:62
/app/vendor/phpunit/phpunit/src/Framework/TestResult.php:453
/app/vendor/phpunit/phpunit/src/Framework/TestSuite.php:685
/app/vendor/phpunit/phpunit/src/Framework/TestSuite.php:685
/app/vendor/phpunit/phpunit/src/Framework/TestSuite.php:685
/app/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:651
/app/vendor/phpunit/phpunit/src/TextUI/Command.php:146
/app/vendor/phpunit/phpunit/src/TextUI/Command.php:99
ERRORS!
Tests: 2, Assertions: 0, Errors: 2, Risky: 1. |
|
@millnut All tests passing now. Okay for this to merge? |
|
@markconroy yep LGTM 👍 |
millnut
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #627
What does this change?
Rewrites the fields.css file to use logical properties. By doing this we can cut down a lot on how much CSS we write and send to the browser.
How to test
Only inline field labels are affected by this file, so set a field label to inline and make sure it works the same as currently.
Thanks to Big Blue Door for sponsoring my time to work on this.