Fix: Address lookup validation #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The address lookup validation process was loosing existing form error messages set by other parts of a form. Some of its own error messages also got lost. WIP.
The LocalGov address lookup element should not tamper with error messages raised by other elements. It should also remain inactive when none of its subelements are marked as required.
|
Marking this pull request as "Draft" to add further improvements. |
The address selection dropdown was not appearing after a form submission error involving the address lookup element. Also: - removed some unused and commented out Javascript code. - improved code comments.
Updated error message text in test code to match updated error handling.
Adding custom error messages to several subelements of the Address lookup element. This is for better UX.
Selecting an address following lookup and then manually altering the selected address skipped validation. Fixed now.
ekes
approved these changes
Nov 20, 2024
| @@ -59,6 +59,9 @@ public static function getCompositeElements(array $element) { | |||
| $element_list['address_1']['#prefix'] = '<div class="js-address-entry-container">'; | |||
| $element_list['postcode']['#suffix'] = '</div>'; | |||
|
|
|||
| // Custom error message for address line 1. | |||
| $element_list['address_1']['#required_error'] = t('You must enter an address.'); | |||
There was a problem hiding this comment.
Not blocking this. But might be worth moving to StringTranslationTrait at some point.
There was a problem hiding this comment.
Yeah. It caused me some unease as well. But eventually stuck to the t() function for consistency with the rest of the file. I have just raised a ticket to replace the entire lot.
Yeah, spotted by @DavidBAsch :D The Address lookup element is a lot better because of him. Thanks for the approval. Merging... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
The LocalGov address lookup element's validation process is losing existing form error messages set by other parts of a form. Some of its own error messages are also getting lost. This change fixes this.
I have also updated the wording for error messages shown on required fields like Address line 1 and Postcode. Instead of saying "Postcode field is required", it now says "You must enter the postcode." Error message wording courtesy of @DavidBAsch
How to test
required.