Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set 'Generate automatic url alias box' for new nodes #408 #426

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

finnlewis
Copy link
Member

No description provided.

@finnlewis
Copy link
Member Author

@stephen-cox this PR is not installing.

It looks like we're trying to alias against LATEST_RELEASE where we actually want a 3.x-dev alias, no?

composer --working-dir=html config repositories.1 vcs [email protected]:${LOCALGOV_DRUPAL_PROJECT}.git
  composer global config github-oauth.github.com ***
  composer --working-dir=./html require --with-all-dependencies ${LOCALGOV_DRUPAL_PROJECT}:"${COMPOSER_REF} as ${LATEST_RELEASE}"
  shell: /usr/bin/bash -e {0}
  env:
    LOCALGOV_DRUPAL_PROJECT: localgovdrupal/localgov_microsites_group
    LOCALGOV_DRUPAL_PROJECT_PATH: web/modules/contrib/localgov_microsites_group
    GIT_BASE: [3](https://github.com/localgovdrupal/localgov_microsites_group/actions/runs/6362377018/job/17277444344?pr=426#step:11:3).x
    GIT_BRANCH: fix/3.x/[4](https://github.com/localgovdrupal/localgov_microsites_group/actions/runs/6362377018/job/17277444344?pr=426#step:11:4)0[8](https://github.com/localgovdrupal/localgov_microsites_group/actions/runs/6362377018/job/17277444344?pr=426#step:11:8)-generate-alias-always-on
    HEAD_USER: localgovdrupal
    COMPOSER_REF: dev-fix/3.x/408-generate-alias-always-on
    LATEST_RELEASE: 2.x-dev
    COMPOSER_PROCESS_TIMEOUT: 0
    COMPOSER_NO_INTERACTION: 1
    COMPOSER_NO_AUDIT: 1
Changed current directory to /home/runner/.composer
./composer.json has been updated
Running composer update localgovdrupal/localgov_microsites_group --with-all-dependencies
Removing package drupal/domain_path so that it can be re-installed and re-patched.
  - Removing drupal/domain_path (1.3.0)
Deleting web/modules/contrib/domain_path - deleted
Loading composer repositories with package information
������������������������������������������������������                                                      ������������������������������������������������������Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - localgovdrupal/localgov_microsites is locked to version 3.x-dev and an update of this package was not requested.
    - localgovdrupal/localgov_microsites 3.x-dev requires localgovdrupal/localgov_microsites_group 3.x-dev -> found localgovdrupal/localgov_microsites_group[3.x-dev] but it conflicts with your root composer.json require (dev-fix/3.x/408-generate-alias-always-on as 2.x-dev).

@finnlewis
Copy link
Member Author

@stephen-cox could you help me work out what's wrong with the test configuration here?

@stephen-cox
Copy link
Member

This is borked due to the Microsites Base theme requiring localgov_microsites_group:3.x-dev while the profile requires localgov_microsites_group:^3.0.0@alpha

Should be fixed with localgovdrupal/localgov_microsites_base#231

@stephen-cox
Copy link
Member

Tests are running again now there's a https://github.com/localgovdrupal/localgov_microsites_base/releases/tag/2.0.0-beta9 release of the theme.

@stephen-cox stephen-cox self-requested a review October 31, 2023 17:07
Copy link
Member

@stephen-cox stephen-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a port to 3.x of changes already in 2.x

@stephen-cox
Copy link
Member

@finnlewis Waiting for you to merge and release 😄

@stephen-cox stephen-cox merged commit ce2aada into 3.x Jan 9, 2024
@stephen-cox stephen-cox deleted the fix/3.x/408-generate-alias-always-on branch January 9, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants