-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More intellegent access control #470
Conversation
…tent types. Requires localgovdrupal/localgov_geo#118 Notes: - Should switch to use the user and group roles we define in the submodules. - Why does Log Out not work? It does outside of tests. - Adding tests for global (non-group path) creation of content when it's included in the access per domain.
Sometimes the repeated / from domain and path matter. Sometimes they don't. Here they do.
In addition to disabling modules per domain. Remove permissions to create (group) content on the control domain.
New route option for redirecting when access is denied to a CSRF protected route https://www.drupal.org/node/3152693 Not sure what it was doing in 10.2 now to work. But this shouldn't break that as it checks for the form first.
…cess-tests-enable-disable-modules
Already exists in optional in localgov_microsites_group_term_ui and localgov_microsites_blogs. Depending on install order one of these can be already existing in configuration when the news config is installed.
…eature/464-access-disabled-modules--plus
…tests-enable-disable-modules
…eature/464-access-disabled-modules--plus
…eature/464-access-disabled-modules--plus
…eature/464-access-disabled-modules--plus
@ekes how best to address:
|
…ed-modules--plus--finn Rework attempt for rendering and listing of themes to remove deprecat…
…types_access_policy service.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests pass, the codings standards and deprecations pass, and the access control works! I think this is ready to merg.
Thank you @ekes and @rupertj and @stephen-cox and @millnut !
Anyone objections to getting this merged on Tuesday? Anyone want to manually test before then? |
I vote for getting this merged |
Sets to finish: