Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to stable group_context_domain and update for API changes. #471

Merged
merged 4 commits into from
May 30, 2024

Conversation

ekes
Copy link
Member

@ekes ekes commented May 28, 2024

No description provided.

@ekes
Copy link
Member Author

ekes commented May 28, 2024

Bumps group_context_domain module up to 1.0.0 (from alpha) and should fix any changes in the API (which also jumped from alpha to stable with just one major change - that I accounted for anyway).

I'd suggest the manual test for this: make sure composer installs 1.0.0 with this, and basic check site.

@finnlewis finnlewis self-assigned this May 29, 2024
@finnlewis
Copy link
Member

Thanks @ekes! I will test.

@finnlewis
Copy link
Member

Without this branch, I get a fatal error on install.


 [notice] Starting Drupal installation. This takes a while.
 [notice] Performed install task: install_select_language
 [notice] Performed install task: install_select_profile
 [notice] Performed install task: install_load_profile
 [notice] Performed install task: install_verify_requirements
 [notice] Performed install task: install_verify_database_ready
 [notice] Performed install task: install_base_system
 [notice] Performed install task: install_bootstrap_full
PHP Fatal error:  Trait "Drupal\group_context_domain\Context\GroupFromDomainContextTrait" not found in /var/www/html/web/modules/contrib/localgov_microsites_group/modules/localgov_microsites_events/src/EventSubscriber/EventsListingCheckEventSubscriber.php on line 17

Fatal error: Trait "Drupal\group_context_domain\Context\GroupFromDomainContextTrait" not found in /var/www/html/web/modules/contrib/localgov_microsites_group/modules/localgov_microsites_events/src/EventSubscriber/EventsListingCheckEventSubscriber.php on line 17
 [warning] Drush command terminated abnormally.
Failed to run drush si localgov_microsites -y: exit status 1
PHP Fatal error:  Trait "Drupal\group_context_domain\Context\GroupFromDomainContextTrait" not found in /var/www/html/web/modules/contrib/localgov_microsites_group/modules/localgov_microsites_events/src/EventSubscriber/EventsListingCheckEventSubscriber.php on line 17

Fatal error: Trait "Drupal\group_context_domain\Context\GroupFromDomainContextTrait" not found in /var/www/html/web/modules/contrib/localgov_microsites_group/modules/localgov_microsites_events/src/EventSubscriber/EventsListingCheckEventSubscriber.php on line 17
 [warning] Drush command terminated abnormally.
Failed to run drush uli: exit status 1

With this branch, the install works!

@finnlewis
Copy link
Member

@ekes I've also tested a local install, created 2 sites as a controller user, assigned users, logged in as admin users and created content. All seems to work very well.

Also, the enable / disable content types seems to work better than recent tests.

Copy link
Member

@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ekes - this all works very well for me locally!

Copy link
Member

@markconroy markconroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed my issue with microsites not installing. Thanks.

@finnlewis
Copy link
Member

Thanks @markconroy !

@finnlewis finnlewis merged commit 6c870cd into 4.x May 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants