-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to stable group_context_domain and update for API changes. #471
Conversation
There's no conflict resolution, so till core updates to type hinting this can simply be moved in.
Bumps group_context_domain module up to 1.0.0 (from alpha) and should fix any changes in the API (which also jumped from alpha to stable with just one major change - that I accounted for anyway). I'd suggest the manual test for this: make sure composer installs 1.0.0 with this, and basic check site. |
Thanks @ekes! I will test. |
Without this branch, I get a fatal error on install.
With this branch, the install works! |
@ekes I've also tested a local install, created 2 sites as a controller user, assigned users, logged in as admin users and created content. All seems to work very well. Also, the enable / disable content types seems to work better than recent tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ekes - this all works very well for me locally!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixed my issue with microsites not installing. Thanks.
Thanks @markconroy ! |
No description provided.