Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check entities being inserted add them to group where appropriate. #480

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

ekes
Copy link
Member

@ekes ekes commented Jun 5, 2024

  • If not being added in a group relationship path.
  • If being added on a group domain.
  • If is a content type that can be added to the group.

Fixes issues such as:

  • User has access to and has managed to navigated to /node/add or /media/add,
  • That media is uploaded in the modal and not immediately added to the group, thus sometimes lost.

 - If not being added in a group relationship path.
 - If being added on a group domain.
 - If is a content type that can be added to the group.
@ekes ekes requested review from finnlewis and stephen-cox June 5, 2024 15:08
@finnlewis finnlewis self-assigned this Jun 6, 2024
@finnlewis
Copy link
Member

I'll test this now!

@finnlewis
Copy link
Member

Yes! This works for me @ekes !

Without this branch, I tested creating media on site1 at /media/add/image. The media was also visible on site 2.

With this branch, created media on site 1 and /media/add/image the media was only available in site 1.

I tested with nodes too,but they did not seem to exhibit the problem in the first place. Nodes created on site 1 and /node/add/page were only visible on site 1.

Happy to merge this!

@finnlewis finnlewis merged commit 98c4e17 into 4.x Jun 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants