release 4.0.0-beta4 #490
Merged
release 4.0.0-beta4 #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If not being added in a group relationship path. - If being added on a group domain. - If is a content type that can be added to the group.
Run tests against Drupal 10.3
…menu_link_reference-module Remove dummy Menu Link Reference module
* Only set 'Generate automatic url alias box' for new nodes #408 * Fixed failing localgov_microsites_group_term_ui tests #396 (#425) * Add 'access microsites overview' permission to control access to the microsites view (#417) * Changed Microsites overview view so it's only accessible to Microsite Controllers #416 * Removed nonexistent permission 'bypass group access' * Added 'access microsites overview' permission * Added update hook to fix microsites overview access for existing sites * Remove 'bypass group access' permission from Microsite controllers * adds lexend font * allows filtering by node title on content listing page * updates to work with microsites 4 * Also override the defalt view display. Question: Is this wise? If the page view in the group module changes upstream, with assumptions about the default this could break. Seen the other way it stops the deault breaking our view. Alternative? Override the other parts of the view that are being added in this MR in our displays, as has been done so far. --------- Co-authored-by: Stephen Cox <[email protected]> Co-authored-by: Finn Lewis <[email protected]> Co-authored-by: Stephen Cox <[email protected]> Co-authored-by: ekes <[email protected]>
…d-content-to-group Check entities being inserted add them to group where appropriate.
Calls to Drupal::service('domain_group_resolver') are causing WSOD :(
`PHP Fatal error: Drupal\localgov_microsites_group\DomainGroupResolver and Drupal\group_context_domain\GroupFromDomainContextTrait define the same property ($domainNegotiator) in the composition of Drupal\localgov_microsites_group\DomainGroupResolver. However, the definition differs and is considered incompatible. Class was composed in /path/to/drupal/web/modules/contrib/localgov_microsites_group/src/DomainGroupResolver.php on line 24`
This is due to [recent changes](https://www.php.net/trait#language.oop5.traits.properties.example) to Drupal\group_context_domain\GroupFromDomainContextTrait
We don't need to declare any class variables. These are all declared in Traits.
…lver-inherited-trait-property-declaration Fix: Inherited trait property declaration
* Start on #464: enabling and disabling modules and access to their content types. Requires localgovdrupal/localgov_geo#118 Notes: - Should switch to use the user and group roles we define in the submodules. - Why does Log Out not work? It does outside of tests. - Adding tests for global (non-group path) creation of content when it's included in the access per domain. * Add logging out to trait. Sometimes the repeated / from domain and path matter. Sometimes they don't. Here they do. * Switch to use group_sites access providers to supply permissions. In addition to disabling modules per domain. Remove permissions to create (group) content on the control domain. * Test broke in 10.3 because of new logout route option for CSRF. New route option for redirecting when access is denied to a CSRF protected route https://www.drupal.org/node/3152693 Not sure what it was doing in 10.2 now to work. But this shouldn't break that as it checks for the form first. * Remove unnecessary (wrong type) translation. * Who knows maybe this works with 10.2 otherwise it's 10.3 only. * Move shared relationship into optional. Already exists in optional in localgov_microsites_group_term_ui and localgov_microsites_blogs. Depending on install order one of these can be already existing in configuration when the news config is installed. * Fuller check of permissions paths. * Add "all" (not quite see comment) admin paths checks. * See if we can test on github against 10.3 * Test now covers all access by content type options. * Upgrade configuration for existing sites. * Add "all" (not quite see comment) admin paths checks. * See if we can test on github against 10.3 * Test now covers all access by content type options. * Add blogs tests (and remove permissions not available from module). * Add blogs tests (and remove permissions not available from module). * Switch branch used for installing microsites to one that installs 10.3 * It's a composer require string? * Oops, pay attention to the branch names. * Script is adding -dev, but it didn't seem to work before. Maybe just wrong string? * Fixing Github Actions * Coding standards fixes * Fix some coding standards. * Rework attempt for rendering and listing of themes to remove deprecated methods. * Move to using constructor property promotion, advised by ru and ekes. * Refactor to use dependency injection. * Fix naming of variables / properties. * Fix missing argument for localgov_microsites_group.microsite_content_types_access_policy service. * Add missing extension.list.theme to create method. * Fix typos in call to moduleHandler. --------- Co-authored-by: Stephen Cox <[email protected]> Co-authored-by: Finn <[email protected]> Co-authored-by: Finn Lewis <[email protected]>
Already exists in optional in localgov_microsites_group_term_ui and localgov_microsites_blogs. Depending on install order one of these can be already existing in configuration when the news config is installed.
…478) * Add blogs tests (and remove permissions not available from module). * Coding standards fix --------- Co-authored-by: Stephen Cox <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.