Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the accessible domain path settings to the active domain #510

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

stephen-cox
Copy link
Member

What does this change?

Hides the path settings for all the domains apart from the active one.

How to test

When editing a page on a site you should only be able to see path settings for the site you're on.

When creating a new node the generate automatic URL checkbox should be checked.

Fixes #509

@stephen-cox
Copy link
Member Author

I have run out of time today to add tests to this. As I thought I had fixed this, but can't see any sign of that, I think it would be worth adding a test to ensure it keeps working.

@finnlewis
Copy link
Member

Tested locally and it works a treat, thanks @stephen-cox !

Do we want to write some tests before merging?

@millnut
Copy link
Member

millnut commented Oct 22, 2024

Looks like the failed tests here and other PRs mentioned today are unrelated as we get them on the main project from this morning's run https://github.com/localgovdrupal/localgov_microsites_project/actions/runs/11454313013/job/31868361713 looks like something needs updating in the group_sites module.

Looks to have started on this run (19th Oct) https://github.com/localgovdrupal/localgov_microsites_project/actions/runs/11415200204

@finnlewis
Copy link
Member

Follow up issue to create tests #516

@finnlewis finnlewis merged commit e7242cb into 4.x Oct 29, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL aliases available for all microsites on a given piece of content
3 participants