Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict types support #108

Closed
Tracked by #685
millnut opened this issue Mar 21, 2024 · 0 comments · Fixed by #112
Closed
Tracked by #685

Strict types support #108

millnut opened this issue Mar 21, 2024 · 0 comments · Fixed by #112

Comments

@millnut
Copy link
Member

millnut commented Mar 21, 2024

With Drupal core moving towards strict types, more info I've added a test pipeline in preparation localgovdrupal/localgov_project#153 which has highlighted some failures which we should fix.

 ------ --------------------------------------------------------------------------- 
  Line   modules/contrib/localgov_news/src/NewsExtraFieldDisplay.php                
 ------ --------------------------------------------------------------------------- 
  167    Parameter #1 $form_object of static method                                 
         Drupal\localgov_news\NewsExtraFieldDisplay::articlePromotedStatus()        
         expects Drupal\node\NodeForm, Drupal\Core\Form\FormInterface given.        
  198    Parameter #2 $article of static method                                     
         Drupal\localgov_news\NewsExtraFieldDisplay::articleSetNewsroomPromote()    
         expects Drupal\node\NodeInterface, Drupal\Core\Entity\EntityInterface      
         given.                                                                     
  201    Parameter #2 $article of static method                                     
         Drupal\localgov_news\NewsExtraFieldDisplay::articleUnsetNewsroomPromote()  
         expects Drupal\node\NodeInterface, Drupal\Core\Entity\EntityInterface      
         given.                                                                     
  222    Call to function in_array() requires parameter #3 to be set.               
  253    Call to function array_search() requires parameter #3 to be set.           
 ------ --------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------- 
  Line   modules/contrib/localgov_news/tests/src/Functional/NewsPageTest.php  
 ------ --------------------------------------------------------------------- 
  185    Call to function in_array() requires parameter #3 to be set.         
  195    Call to function in_array() requires parameter #3 to be set.         
  211    Call to function in_array() requires parameter #3 to be set.         
  213    Call to function in_array() requires parameter #3 to be set.         
  215    Call to function in_array() requires parameter #3 to be set.         
  217    Call to function in_array() requires parameter #3 to be set.         
  232    Call to function in_array() requires parameter #3 to be set.         
  234    Call to function in_array() requires parameter #3 to be set.         
  236    Call to function in_array() requires parameter #3 to be set.         
  238    Call to function in_array() requires parameter #3 to be set.         
 ------ --------------------------------------------------------------------- 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant