Testing multiple branches - do not merge!

[finnlewis]

Testing multiple branches, please don't merge,.

[finnlewis]

@markconroy @stephen-cox @ekes I'd love to get this PR working to demonstrate that the 1.7.0 version of the localgov_base will work.

Currently I'm getting lots of this locally:

Unable to install theme: 'localgov_base' due to unmet module dependencies: 'localgov_base_helper'.

I note that the localgov_base_helper module is inside the theme. Is this OK? Can a theme depend on a module that is in the itself?

[finnlewis]

@ekes @stephen-cox @markconroy I'm still scratching my head with this one, any ideas?

[finnlewis]

Steps to test:

composer create-project localgovdrupal/localgov-project:dev-feature/740-localgov-base MY_PROJECT --no-cache  --no-install
cd MY_PROJECT
ddev start
ddev composer install
ddev composer require drupal/group
ddev phpunit

[finnlewis]

Possible ways forward:

1. review all tests that are failing and add explicit dependency on the localgov_base_helper module?
2. break out the module into a separate module?

[finnlewis]

Running tests locally:

There were 15 errors:

1) Drupal\Tests\localgov_core\Functional\DefaultBlockTest::testBlockDisplay
Drupal\Core\Extension\MissingDependencyException: Unable to install theme: 'localgov_base' due to unmet module dependencies: 'localgov_base_helper'.

/var/www/html/web/core/lib/Drupal/Core/Extension/ThemeInstaller.php:176
/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:466
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:574
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

2) Drupal\Tests\localgov_core\Functional\OnOffSwitchTest::testOnOffSwitch with data set #0 (true, true)
Drupal\Core\Extension\MissingDependencyException: Unable to install theme: 'localgov_base' due to unmet module dependencies: 'localgov_base_helper'.

/var/www/html/web/core/lib/Drupal/Core/Extension/ThemeInstaller.php:176
/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:466
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:574
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

3) Drupal\Tests\localgov_core\Functional\OnOffSwitchTest::testOnOffSwitch with data set #1 (false, false)
Drupal\Core\Extension\MissingDependencyException: Unable to install theme: 'localgov_base' due to unmet module dependencies: 'localgov_base_helper'.

/var/www/html/web/core/lib/Drupal/Core/Extension/ThemeInstaller.php:176
/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:466
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:574
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

4) Drupal\Tests\localgov_news\Functional\NewsPageTest::testNewsFields
Drupal\Core\Extension\MissingDependencyException: Unable to install theme: 'localgov_base' due to unmet module dependencies: 'localgov_base_helper'.

/var/www/html/web/core/lib/Drupal/Core/Extension/ThemeInstaller.php:176
/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:466
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:574
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/var/www/html/web/modules/contrib/localgov_news/tests/src/Functional/NewsPageTest.php:60
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

5) Drupal\Tests\localgov_news\Functional\NewsPageTest::testNewsEditForm
Drupal\Core\Extension\MissingDependencyException: Unable to install theme: 'localgov_base' due to unmet module dependencies: 'localgov_base_helper'.

/var/www/html/web/core/lib/Drupal/Core/Extension/ThemeInstaller.php:176
/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:466
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:574
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/var/www/html/web/modules/contrib/localgov_news/tests/src/Functional/NewsPageTest.php:60
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

6) Drupal\Tests\localgov_news\Functional\NewsPageTest::testNewsEditPromoteCheckbox
Drupal\Core\Extension\MissingDependencyException: Unable to install theme: 'localgov_base' due to unmet module dependencies: 'localgov_base_helper'.

/var/www/html/web/core/lib/Drupal/Core/Extension/ThemeInstaller.php:176
/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:466
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:574
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/var/www/html/web/modules/contrib/localgov_news/tests/src/Functional/NewsPageTest.php:60
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

7) Drupal\Tests\localgov_news\Functional\NewsPageTest::testNewsPages
Drupal\Core\Extension\MissingDependencyException: Unable to install theme: 'localgov_base' due to unmet module dependencies: 'localgov_base_helper'.

/var/www/html/web/core/lib/Drupal/Core/Extension/ThemeInstaller.php:176
/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:466
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:574
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/var/www/html/web/modules/contrib/localgov_news/tests/src/Functional/NewsPageTest.php:60
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

8) Drupal\Tests\localgov_news\Functional\NewsSearchTest::testNewsSearch
Drupal\Core\Extension\MissingDependencyException: Unable to install theme: 'localgov_base' due to unmet module dependencies: 'localgov_base_helper'.

/var/www/html/web/core/lib/Drupal/Core/Extension/ThemeInstaller.php:176
/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:466
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:574
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/var/www/html/web/modules/contrib/localgov_news/tests/src/Functional/NewsSearchTest.php:52
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

9) Drupal\Tests\localgov_news\Functional\NewsSearchTest::testLocalgovSearch
Drupal\Core\Extension\MissingDependencyException: Unable to install theme: 'localgov_base' due to unmet module dependencies: 'localgov_base_helper'.

/var/www/html/web/core/lib/Drupal/Core/Extension/ThemeInstaller.php:176
/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:466
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:574
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/var/www/html/web/modules/contrib/localgov_news/tests/src/Functional/NewsSearchTest.php:52
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

10) Drupal\Tests\localgov_publications\Functional\PublicationPageNavigationTest::testPreviousNextLinks
Behat\Mink\Exception\ExpectationException: The string "<a href="/publication-parent-page" rel="prev" title="Go to previous page">" was not found anywhere in the HTML response of the current page.

/var/www/html/vendor/behat/mink/src/WebAssert.php:888
/var/www/html/vendor/behat/mink/src/WebAssert.php:363
/var/www/html/web/core/tests/Drupal/Tests/WebAssert.php:558
/var/www/html/web/modules/contrib/localgov_publications/tests/src/Functional/PublicationPageNavigationTest.php:94
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

11) Drupal\Tests\localgov_services\Functional\ServicesBlockTest::testServiceCoreBlocksDisplay
Drupal\Core\Extension\MissingDependencyException: Unable to install theme: 'localgov_base' due to unmet module dependencies: 'localgov_base_helper'.

/var/www/html/web/core/lib/Drupal/Core/Extension/ThemeInstaller.php:176
/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:466
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:574
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

12) Drupal\Tests\localgov_step_by_step\FunctionalJavascript\StepByStepSummariesTest::testStepSummaryVisibility
Drupal\Core\Extension\MissingDependencyException: Unable to install theme: 'localgov_base' due to unmet module dependencies: 'localgov_base_helper'.

/var/www/html/web/core/lib/Drupal/Core/Extension/ThemeInstaller.php:176
/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:466
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:574
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

13) Drupal\Tests\localgov_subsites\Functional\SubsiteBlocksTest::testSubsiteBannerBlock
Drupal\Core\Extension\MissingDependencyException: Unable to install theme: 'localgov_base' due to unmet module dependencies: 'localgov_base_helper'.

/var/www/html/web/core/lib/Drupal/Core/Extension/ThemeInstaller.php:176
/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:466
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:574
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/var/www/html/web/modules/contrib/localgov_subsites/tests/src/Functional/SubsiteBlocksTest.php:56
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

14) Drupal\Tests\localgov_subsites\Functional\SubsiteBlocksTest::testSubsiteNavigationBlock
Drupal\Core\Extension\MissingDependencyException: Unable to install theme: 'localgov_base' due to unmet module dependencies: 'localgov_base_helper'.

/var/www/html/web/core/lib/Drupal/Core/Extension/ThemeInstaller.php:176
/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:466
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:574
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/var/www/html/web/modules/contrib/localgov_subsites/tests/src/Functional/SubsiteBlocksTest.php:56
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

15) Drupal\Tests\localgov_subsites\Functional\SubsiteBlocksTest::testSubsiteBlocksOnCreateNodePage
Drupal\Core\Extension\MissingDependencyException: Unable to install theme: 'localgov_base' due to unmet module dependencies: 'localgov_base_helper'.

/var/www/html/web/core/lib/Drupal/Core/Extension/ThemeInstaller.php:176
/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:466
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:574
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/var/www/html/web/modules/contrib/localgov_subsites/tests/src/Functional/SubsiteBlocksTest.php:56
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

--

There was 1 failure:

1) Drupal\Tests\localgov\Functional\LocalGovUpdateTest::testUpdate
The link Continue was not found on the page.
Failed asserting that an array has the key 0.