Merge pull request #274 from localgovdrupal/fix/2.x/273-phpstan-failures

Fix static anaysis checks
localgovdrupal · Aug 13, 2024 · 69275d3 · 69275d3
2 parents e37e329 + 3f046a9
commit 69275d3
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 15 deletions.
diff --git a/modules/localgov_services_navigation/src/EntityChildRelationshipUi.php b/modules/localgov_services_navigation/src/EntityChildRelationshipUi.php
@@ -198,6 +198,9 @@ protected function childrenField(NodeInterface $node) {
    *
    * @param \Drupal\node\NodeInterface $node
    *   The `localgov_service_landing` or `localgov_service_sublanding`.
+   *
+   * @return array
+   *   Array of node IDs.
    */
   public static function referencedChildren(NodeInterface $node) {
     $linked = [];

diff --git a/...ces_navigation/tests/src/FunctionalJavascript/EntityReferenceServicesAutocompleteTest.php b/...ces_navigation/tests/src/FunctionalJavascript/EntityReferenceServicesAutocompleteTest.php
@@ -4,7 +4,7 @@
 
 use Drupal\FunctionalJavascriptTests\WebDriverTestBase;
 use Drupal\node\NodeInterface;
-use Drupal\Tests\field\Traits\EntityReferenceTestTrait;
+use Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait;
 use Drupal\Tests\node\Traits\ContentTypeCreationTrait;
 use Drupal\Tests\node\Traits\NodeCreationTrait;
 
@@ -16,10 +16,7 @@
 class EntityReferenceServicesAutocompleteTest extends WebDriverTestBase {
 
   use ContentTypeCreationTrait;
-  // FIXME: Replace with EntityReferenceFieldCreationTrait when Drupal 10.1 is
-  // end of life.
-  // @phpstan-ignore-next-line.
-  use EntityReferenceTestTrait;
+  use EntityReferenceFieldCreationTrait;
   use NodeCreationTrait;
 
   /**

diff --git a/modules/localgov_services_navigation/tests/src/Kernel/ChildReferencesTest.php b/modules/localgov_services_navigation/tests/src/Kernel/ChildReferencesTest.php
@@ -10,7 +10,7 @@
 use Drupal\node\NodeInterface;
 use Drupal\paragraphs\Entity\Paragraph;
 use Drupal\taxonomy\Entity\Term;
-use Drupal\Tests\field\Traits\EntityReferenceTestTrait;
+use Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait;
 use Drupal\Tests\node\Traits\ContentTypeCreationTrait;
 use Drupal\Tests\node\Traits\NodeCreationTrait;
 use Drupal\Tests\pathauto\Functional\PathautoTestHelperTrait;
@@ -24,10 +24,7 @@
 class ChildReferencesTest extends KernelTestBase {
 
   use ContentTypeCreationTrait;
-  // FIXME: Replace with EntityReferenceFieldCreationTrait when Drupal 10.1 is
-  // end of life.
-  // @phpstan-ignore-next-line.
-  use EntityReferenceTestTrait;
+  use EntityReferenceFieldCreationTrait;
   use NodeCreationTrait;
   use PathautoTestHelperTrait;
 

diff --git a/modules/localgov_services_navigation/tests/src/Kernel/ParentFieldPathautoTest.php b/modules/localgov_services_navigation/tests/src/Kernel/ParentFieldPathautoTest.php
@@ -5,7 +5,7 @@
 use Drupal\KernelTests\KernelTestBase;
 use Drupal\language\Entity\ConfigurableLanguage;
 use Drupal\node\NodeInterface;
-use Drupal\Tests\field\Traits\EntityReferenceTestTrait;
+use Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait;
 use Drupal\Tests\node\Traits\ContentTypeCreationTrait;
 use Drupal\Tests\node\Traits\NodeCreationTrait;
 use Drupal\Tests\pathauto\Functional\PathautoTestHelperTrait;
@@ -18,10 +18,7 @@
 class ParentFieldPathautoTest extends KernelTestBase {
 
   use ContentTypeCreationTrait;
-  // FIXME: Replace with EntityReferenceFieldCreationTrait when Drupal 10.1 is
-  // end of life.
-  // @phpstan-ignore-next-line.
-  use EntityReferenceTestTrait;
+  use EntityReferenceFieldCreationTrait;
   use NodeCreationTrait;
   use PathautoTestHelperTrait;