Update service blocks to use a node route context #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybroomfield
force-pushed
the
fix/116-layout-builder-block-support
branch
from
8524580 to
2fbf3d2
Compare
|
Discussing in Merge Tuesday:
|
Ref #116 Add the node context to the service blocks, this allows them to be used with layout builder
Set a node context to all service blocks and update the block base and all service
block functions to use the contextValue('node') if present.
Update each of the provided blocks to set a context_mapping for the current node route
Provide update hooks for CTA, releated links and related topics blocks
Provide a backward compatible way of accessing the current node via $this->node
for blocks that have not updated to use a node context so they can still get the current
node. (todo: decide if this should then be deprecated).
andybroomfield
force-pushed
the
fix/116-layout-builder-block-support
branch
from
2fbf3d2 to
8b4547c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #116
Changes the way services blocks get the current node, by changing from using the current route in the constructor and using a context mapping for the node route.
This allows the correct contents of the blocks to display in other modules such as layout builder.
To achive this, the provided blocks will need to be updated on existing sites with the update hook provided, this will add the required node context to the CTA, releated links and releated topics blocks.
The existing $this->node method is still present for backward compatability for other blocks that extend servicesBlockBase until they are updated to use the node route context value.