Upgrade link attributes to 2.x branch #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #270 Set min version to 2.1 as 1.x branch unsupported.
ekes
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #270
Set min version to 2.1 as 1.x branch unsupported.
What does this change?
Upgrades to 2.x branch
How to test
Along with localgovdrupal/localgov_news#116 there should no longer be an unsupported module message.
How can we measure success?
Link attributes are still present on service pages related links (except they don't actually do anything as localgov_base does not support them), there should be a target option.
No more unsupported module error messages.
Have we considered potential risks?
Standard module major upgrade risks apply.
Images
n/a
Accessibility
n/a