Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node access patch as 10.2 no longer supported #293

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

andybroomfield
Copy link
Contributor

@andybroomfield andybroomfield commented Dec 23, 2024

Fix #263
Fix #292

What does this change?

Remove the patch "node_access filters out accessible nodes when node is left joined (1349080)"
This patch will still be required for Drupal installs <10.3, but they should no longer be used.

How to test

As per the original issue, #231 and #147.
Install a module that uses a node_access hook. Eg. View unpublished.

Try to create a service page and service landing page, users should still be able to reference a serivce landing page in the parent if they have persmission to view it.
(Will require using the editor role).

How can we measure success?

Cleaner deploys, service page structure remains intact.

Have we considered potential risks?

Councils may be staying on 10.2 which is now unsupported, they will need to reapply the patch.

Images

n/a

Accessibility

n/a

Fix #263
Fix #292

This patch will still be required for Drupal installs <10.3, but they should
no longer be used.
@ekes
Copy link
Member

ekes commented Jan 7, 2025

#265

Though we might as well go with this one, as it's applying.
In either case it's clear from previous PR, and the issues, that it's been tested and accepted.

@finnlewis finnlewis merged commit 46fda08 into 2.x Jan 7, 2025
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove patch Failing drupal core patch
3 participants