Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update featured teasers to follow Drupal standards better #29

Draft
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

markconroy
Copy link
Member

Some small tweaks to add extra BEM classes to our featured teasers templates.

@finnlewis finnlewis changed the base branch from 1.x to 2.x January 10, 2022 14:42
@finnlewis
Copy link
Member

@cjstevens78 @Adnan-cds would this have any impact on Croydon?

@Adnan-cds
Copy link
Contributor

would this have any impact on Croydon?

Chris will know better. @cjstevens78

@cjstevens78
Copy link
Contributor

would this have any impact on Croydon?

Chris will know better. @cjstevens78

@finnlewis no impact over here good to go

@markconroy
Copy link
Member Author

Let's hold off of merging this for a little bit. I want to make sure we have the same markup in this template as we have in our localgov_base theme for maximum consistency.

@finnlewis
Copy link
Member

@markconroy would still like to check the markup for maximum consistency as mentioned above.

@finnlewis finnlewis marked this pull request as draft April 25, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants