Specify Docker Desktop in development-environment-setup.md #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list of required tools mentions `docker`, but that is a umbrella-term for a lot of things. Renaming it to `Docker Desktop` makes it more obvious that this specific Docker tool is required. The additional Tip is to help people if they happen to have only the Docker engine installed. One might think that the Docker Engine is enough, but newer versions of the engine do not include `buildx` by default, and building the LS Docker image fails in an odd way of `buildx` cannot be found.
|
🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1058.surge.sh 🎊 |
HarshCasper
reviewed
Feb 17, 2025
There was a problem hiding this comment.
Hi Bert — Apologies for not looking into this earlier! We have migrated the development environment setup guide to the LocalStack repo. Would you mind to raise a PR over here — https://github.com/localstack/localstack/tree/master/docs/development-environment-setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of required tools mentions
docker, but that is a umbrella-term for a lot of things. Renaming it toDocker Desktopmakes it more obvious that this specific Docker tool is required.The additional Tip is to help people who only have the Docker engine installed. One might think that the Docker Engine is enough, but newer versions of the engine do not include
buildxby default, and building the LS Docker image fails in an odd way ofbuildxcannot be found.