-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-162 handle empty point / shape collection in toString #183
GH-162 handle empty point / shape collection in toString #183
Conversation
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
============================================
+ Coverage 75.03% 75.09% +0.06%
- Complexity 1092 1095 +3
============================================
Files 57 57
Lines 3805 3811 +6
Branches 772 774 +2
============================================
+ Hits 2855 2862 +7
Misses 671 671
+ Partials 279 278 -1
Continue to review full report at Codecov.
|
12f8b11
to
028a36a
Compare
Thanks! Please add a CHANGES.md entry and then I look forward to squash-merging this! |
Maybe |
Details of the problem are explained here: locationtech#177 The new test-case fails without the code change and passes after the code change. Signed-off-by: Hrishi Bakshi <[email protected]>
Signed-off-by: Hrishi Bakshi <[email protected]>
…g an exception. Fixes locationtech#163
Signed-off-by: Jeen Broekstra <[email protected]>
028a36a
to
689b41d
Compare
Signed-off-by: Jeen Broekstra <[email protected]>
07081e7
to
0485785
Compare
I've added a changelog entry - had to force-push as I forgot to sign off at first. Not sure where the conflict comes from as I only added the one line, but I'll leave that in your capable hands :) |
I have some changes that more extensively work across GeoJson as well and testing. I tried to push to your PR but it was rejected. Have you seen this?: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork |
Peculiar - the "allow edits from maintainers" option was already enabled, so you should have been able to push to my branch. One way to solve this if you create a new feature branch for this change in the main repo, then re-target this PR to that feature branch, merge it, and then do your own additional changes on top. But if you prefer doing a PR on my fork instead that's fine too - whatever works for you :) |
I was mistaken; my initial attempts to push to your branch were actually to a new branch and not to your existing. I corrected that and as you can see they are here now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Added corner case handling for serializing points and shape collections to string.
Fixes issue GH-162