Merge pull request #802 from DMKEBUSINESSGMBH/master

[BUGFIX] do not register flex_form field if no services
lochmueller · May 16, 2024 · 6be1552 · 6be1552
2 parents cebc2cc + 0e95de5
commit 6be1552
Showing 1 changed file with 21 additions and 19 deletions.
diff --git a/Configuration/TCA/Overrides/tx_calendarize_domain_model_configuration.php b/Configuration/TCA/Overrides/tx_calendarize_domain_model_configuration.php
@@ -11,28 +11,30 @@
 $secondaryTimeTableService = GeneralUtility::makeInstance(SecondaryTimeTableService::class);
 $services = $secondaryTimeTableService->getSecondaryTimeTables();
 
-if (!empty($services)) {
-    ExtensionManagementUtility::addTcaSelectItemGroup(
+if (empty($services)) {
+    return;
+}
+
+ExtensionManagementUtility::addTcaSelectItemGroup(
+    'tx_calendarize_domain_model_configuration',
+    'type',
+    'secondary',
+    'Secondary'
+);
+foreach ($services as $service) {
+    $timeTable = [
+        'label' => $service->getLabel(),
+        'value' => $service->getIdentifier(),
+        'group' => 'secondary',
+    ];
+    $flexForms[$service->getIdentifier()] = $service->getFlexForm();
+    ExtensionManagementUtility::addTcaSelectItem(
         'tx_calendarize_domain_model_configuration',
         'type',
-        'secondary',
-        'Secondary'
+        $timeTable
     );
-    foreach ($services as $service) {
-        $timeTable = [
-            'label' => $service->getLabel(),
-            'value' => $service->getIdentifier(),
-            'group' => 'secondary',
-        ];
-        $flexForms[$service->getIdentifier()] = $service->getFlexForm();
-        ExtensionManagementUtility::addTcaSelectItem(
-            'tx_calendarize_domain_model_configuration',
-            'type',
-            $timeTable
-        );
-        $GLOBALS['TCA']['tx_calendarize_domain_model_configuration']['ctrl']['typeicon_classes'][$service->getIdentifier()] = 'apps-calendarize-type-' . Configuration::TYPE_TIME;
-        $GLOBALS['TCA']['tx_calendarize_domain_model_configuration']['types'][$service->getIdentifier()]['showitem'] = $service->getTcaServiceTypeFields();
-    }
+    $GLOBALS['TCA']['tx_calendarize_domain_model_configuration']['ctrl']['typeicon_classes'][$service->getIdentifier()] = 'apps-calendarize-type-' . Configuration::TYPE_TIME;
+    $GLOBALS['TCA']['tx_calendarize_domain_model_configuration']['types'][$service->getIdentifier()]['showitem'] = $service->getTcaServiceTypeFields();
 }
 ExtensionManagementUtility::addTCAcolumns(
     'tx_calendarize_domain_model_configuration',