Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty tags result as empty list even if folder is good #304

Merged
merged 1 commit into from
Feb 20, 2024
Merged

fix: empty tags result as empty list even if folder is good #304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Chat.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ const Chat: React.FC<ChatProps> = ({
// Recursively get all note TFiles in the path
noteFiles = await getNotesFromPath(vault, settings.chatNoteContextPath);
}
if (settings.chatNoteContextTags) {
if (settings.chatNoteContextTags.length > 0) { //prevent overriding chatNoteContextPath if not tags are used
// Get all notes with the specified tags
// If path is provided, get all notes with the specified tags in the path
// If path is not provided, get all notes with the specified tags
Expand Down
Loading