Fix o1-preview model support in Azure OpenAI #904
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #903 Update code to support Azure OpenAI `o1-preview` model with `maxCompletionTokens` property. * Add `maxCompletionTokens` property to `ModelConfig` interface in `src/aiParams.ts`. * Update `handleOpenAIExtraArgs` method in `src/LLMProviders/chatModelManager.ts` to set `maxCompletionTokens` property for `o1-preview` model. * Pass `maxCompletionTokens` property to `ChatOpenAI` constructor in `getModelConfig` method in `src/LLMProviders/chatModelManager.ts`. * Update `createChainWithNewModel` and `setChain` methods in `src/LLMProviders/chainManager.ts` to handle `o1-preview` model. * Add specific mention of `o1-preview` model support in Azure OpenAI section in `README.md`. * Add instructions for setting up `o1-preview` model in Azure OpenAI section in `src/settings/components/ApiSettings.tsx`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/logancyang/obsidian-copilot/issues/903?shareId=XXXX-XXXX-XXXX-XXXX).
* **src/aiParams.ts**: Add `maxCompletionTokens` property to `ModelConfig` interface. * **src/LLMProviders/chainManager.ts**: Update `createChainWithNewModel` and `setChain` methods to handle `o1-preview` model. * **README.md**: Add mention of `o1-preview` model support in Azure OpenAI section. * **src/settings/components/ApiSettings.tsx**: Add instructions for setting up `o1-preview` model in Azure OpenAI section.
* **src/aiParams.ts** - Add `maxCompletionTokens` property to `ModelConfig` interface * **src/LLMProviders/chainManager.ts** - Update `setChain` method to accept `SetChainOptions` - Add `getEffectivePrompt` method to handle `o1-preview` model prompt * **README.md** - Add instructions for setting up `o1-preview` model in Azure OpenAI section * **src/settings/components/ApiSettings.tsx** - Add specific instructions for `o1-preview` model configuration in Azure OpenAI section
|
Looks like code duplication with #850 |
logancyang
requested changes
Dec 7, 2024
…axTokens` and `temperature` * **src/aiParams.ts** - Add `maxCompletionTokens` as an optional parameter in `ModelConfig` interface - Ensure `temperature` is set to 1 for `o1-preview` models in `ModelConfig` interface - Add `azureOpenAIApiDeploymentName` as an optional parameter in `CustomModel` interface * **src/LLMProviders/chatModelManager.ts** - Add validation for `maxTokens` and `temperature` in `getModelConfig` method - Add `handleAzureOpenAIExtraArgs` method to handle Azure OpenAI extra arguments - Update Azure OpenAI configuration in `getModelConfig` method * **src/settings/components/ApiSettings.tsx** - Add specific instructions for setting up `o1-preview` model in Azure OpenAI section
|
Still running into connection error issues.. |
…am to exclude streaming logic for the `o1-preview` model * **chainManager.ts** - Update `createChainWithNewModel` to handle `o1-preview` model settings - Modify `setChain` to exclude streaming logic for `o1-preview` model * **chatModelManager.ts** - Update `getModelConfig` to set `streaming` property to `false` for `o1-preview` model - Validate `maxTokens` and `temperature` settings * **chainRunner.ts** - Update `handleResponse` and `handleRetrievalResponse` to exclude streaming logic for `o1-preview` model * **langchainStream.ts** - Add `streamLangChain` and `streamMultimodal` functions to handle streaming logic - Exclude streaming logic for `o1-preview` model
Added azureOpenAIApiInstanceName and azureOpenAIApiVersion properties to the CustomModel interface to resolve TypeScript errors related to missing properties. src/LLMProviders/chatModelManager.ts: Corrected import paths to use relative paths, ensuring the correct modules are imported. Handled the openAIOrgId property separately by adding it to the configuration object only when necessary, using a type assertion to bypass TypeScript's type checking for this specific property. Ensured all parameters have explicit types to avoid implicit any type errors.
logancyang
reviewed
Dec 9, 2024
src/aiParams.ts
Outdated
| @@ -73,6 +67,7 @@ export interface CustomModel { | |||
| isBuiltIn?: boolean; | |||
| enableCors?: boolean; | |||
| core?: boolean; | |||
| azureOpenAIApiDeploymentName?: string; // Added for Azure OpenAI models | |||
There was a problem hiding this comment.
Isn't this the same as the one above?
There was a problem hiding this comment.
I'm just trying to remove the last 2 commits I made - struggling.
There was a problem hiding this comment.
But to answer your question, currently when choosing custom model, you are not given a choice of selecting a model with your deployment ID. I might be wrong, but my testing has made me believe that several gpt-4o models are available on one azure openai deployment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #903
Update code to support Azure OpenAI
o1-previewmodel withmaxCompletionTokensproperty.maxCompletionTokensproperty toModelConfiginterface insrc/aiParams.ts.handleOpenAIExtraArgsmethod insrc/LLMProviders/chatModelManager.tsto setmaxCompletionTokensproperty foro1-previewmodel.maxCompletionTokensproperty toChatOpenAIconstructor ingetModelConfigmethod insrc/LLMProviders/chatModelManager.ts.createChainWithNewModelandsetChainmethods insrc/LLMProviders/chainManager.tsto handleo1-previewmodel.o1-previewmodel support in Azure OpenAI section inREADME.md.o1-previewmodel in Azure OpenAI section insrc/settings/components/ApiSettings.tsx.For more details, open the Copilot Workspace session.