Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed grunt minification and dependency injection bug #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tahashahid
Copy link

fixed angular dependency injection issue
removed unnecessary dependency on 'ngAudioRecorderWaveView' directive

run gulp task for buil dist

dependency injection not working when trying to minified and concatinate scripts using grunt because of diffrent names of functions and $injector not work with some grunt modules

Please review my changes and merge them

removed unnecessary dependency on 'ngAudioRecorderWaveView' directive

run gulp task for buil dist
@shonatodc
Copy link

Good call, I just did this to the code locally. Also all the inline annotation's are kind of inefficient, just IMO.

@kspandana
Copy link

recording part is working fine with localhost
but when I tried running it with hostname as system ip and running it using grunt got some error
"$apply already in progress"..
May i know why this error is being encountered and how it can be resolved??

@paulfleming2004
Copy link

@kspandana In recorder-controller.js line 237 (for me but I have some tweaks) reads $scope.$apply(). This should be scopeApply();. On localhost, permission will be denied and the the onDenied event is fired. Here's the altered block:

service.showPermission({
    onDenied: function () {
        status.isDenied = true;
        //$scope.$apply();
        scopeApply();
    },

@edelfrade
Copy link

Was there a reason this was never fixed/merged? I know AngularJS is a bit old by now but this is a pretty great recorder. Concatenate/uglify continues breaking it.

@RomanAnass
Copy link

bonjour , comment peut-on executer cette application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants