Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bus_template.json #98

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update bus_template.json #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions examples/bus_template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,12 @@
"number_of_replicas" : 0
},
"mappings": {
"_default_": {
"_all": { "enabled": false },
"_source": { "compress": true },
"properties" : {
"_doc": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since _doc is only allowed in elasticsearch 6.2+ (prior to this types can't start with underscore), I'm a bit concerned with accepting this change, which won't work for anyone testing with a <6.2 es cluster. thoughts?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defaults is not allowed in elasticsearch 6.*
So it's similar concern I suppose?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately this is not obvious but _default_ is treated differently. Installing a template with _default_ on 6.1.2 will work, but _doc not.

That said, the template as it is doesn't work on 6.1.2 either because it still uses the string type which is no longer valid since 6.0

"properties" : {
"location": { "type": "geo_point" },
"@tags": { "type": "string", "index" : "not_analyzed" },
"@timestamp" : { "type" : "date", "index" : "not_analyzed" }
}
}
}
}
}